ModelSurge / sd-webui-comfyui

An extension to integrate ComfyUI workflows into the Webui's pipeline
MIT License
504 stars 32 forks source link

ConfyUI using domain #82

Closed Harao90 closed 1 year ago

Harao90 commented 1 year ago

I have my Stable Diffusion "public" and was trying to have ConfyUI on it, but I can't configure the page the tab is trying to go, so it goes to the local host. is there any way I can redirect it to my domain or do I have to do a workaround?

In the machine where I am running Stable Diffusion it all works as intended.

image

ljleb commented 1 year ago

Are you trying to run both the webui and comfyui on the same machine, or you are trying to start comfyui on a different machine from the webui?

At the moment, it is not possible to separate them. We are considering making this possible, although it is not a priority ATM.

If you simply need the webui to try to connect to a different url for some reason, then you can change the "Address of the ComfyUI server as seen from the webui" in the settings of the extension.

ljleb commented 1 year ago

Note that you have to wait for the comfyui server to finish loading before opening a web browser at the webui URL ATM for it to work. Keep an eye on #77 for the resolution of that issue.

Harao90 commented 1 year ago

Are you trying to run both the webui and comfyui on the same machine, or you are trying to start comfyui on a different machine from the webui?

At the moment, it is not possible to separate them. We are considering making this possible, although it is not a priority ATM.

If you simply need the webui to try to connect to a different url for some reason, then you can change the "Address of the ComfyUI server as seen from the webui" in the settings of the extension.

You mean this right? image

I thought that was it too, Didn't work, tries to connect to the local host as in the first post.

They are running on the same machine, I have a web server doing reverse proxy to stable diffusion so i can access it via a domain sd.mydomain.com, and it works. I have done the same thing for the confyui too. confy.mydomain.com and it works directly too. I wanted to make the tab on stable diffusion access but it always tries to connect to the local host. i have tried with private IPs too.

ljleb commented 1 year ago

I see. Can you share your logs? Is there a message that looks like "[ComfyUI extension] changing the ComfyUI client address from {client_url} to {loopback_address}"?

Harao90 commented 1 year ago

Found this

image

i am trying to use --webui-comfyui-client-address

, adding "--client-address confy.domain.com" to the Additional cli arguments on stable diffusion webui, but it says the argument is not right, but i think it is on the right path.

ljleb commented 1 year ago

The argument has to be --webui-comfyui-client-address confy.domain.com, not just "--client-address". However it's odd that the settings are ignored. Are you sure they have been saved, and then you reloaded the ui or the server completely? The settings should take priority over the cli arguments.

Harao90 commented 1 year ago

got some progress

image

Not working yet, but it is starting to appear something is changing, i tried with the domain and it puts the http and port automatically so i thought it was because of that. Change it to just the ip, and the same result, all white.

ill try some more things and give feedback.

if you think of something please say, for now ill continue using it as i had before and tackle this later, it was just to have everything in one place.

Thanks for the help!

ljleb commented 1 year ago

Wait, which webui host is this? It does not look like a1111 or vlad. We can't support all possible webui hosts implementation, it just wouldn't be practical to aim for this... Does the extension work for your use case in a1111 or vlad, or it also fails there?

Harao90 commented 1 year ago

image

it works if everything is local,

Lobe Theme, former kitchen theme. https://github.com/canisminor1990/sd-webui-lobe-theme/releases

ljleb commented 1 year ago

Do I understand that the issue is resolved then? Or your earlier setup is also a local installation that did not work for some reason

Harao90 commented 1 year ago

Do I understand that the issue is resolved then? Or your earlier setup is also a local installation that did not work for some reason

It is not resolved, I put everything to default and used the local machine to show it works as intended.

When I access from my domain, everything is default, it can't connect to confyUI because it tries to access 127.0.0.1 and fails, as it should. When I use the --webui-comfyui-client-address confy.domain.com or --webui-comfyui-client-address 192.168.x.x it gives no error just white.

When I have time ill try a new a1111 installation just with the extension to try to isolate the issue.

ljleb commented 1 year ago

Ah wait, now I understand your setup. I don't have a domain name to test with, so it's hard for me to debug this. I'm not sure why the ui is all white like that. In the end, the comfyui tab we added is really just an iframe trying to load the content from a specified address. The tab shouldn't do anything special on the ui side.

Maybe it's stuck for some reason during loading? I'm not quite sure. Could you share the entire logs? It may show whether comfyui is starting or not. Maybe I could spot a clue in there.

E2GO commented 1 year ago

Same issue.

ljleb commented 1 year ago

For reverse proxy users, IIUC the problem is that reverse proxy needs to be implemented for comfyui in addition to the existing reverse proxy for the webui.

We were considering adding a local tunnel implementation but it turned out to be a lot of work. we may add it some time in the future. PRs are welcome for this use case. We are currently focusing on more urgent matters, but may come back to this at some point.

ljleb commented 1 year ago

related: #9

ljleb commented 1 year ago

91 should have fixed the url setting not being taken into account. @Harao90 let us know if the issue is fixed on your end with this option.

ljleb commented 1 year ago

A solution for reverse proxy to work without setting up separate proxies for the webui and comfyui would be to setup a specific route in a1111, for example http://localhost:7860/sd-webui-comfyui/comfyui, as a reverse proxy to http://localhost:8189 (actual comfyui server). Then we can point the iframes to the new url and stop worrying about CORS and whatnot

rookiexjl commented 1 year ago

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

vivagonna commented 1 year ago

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

Seems not work

pre_main.py: error: unrecognized arguments: --webui-comfyui-client-address 0.0.0.0

rookiexjl commented 1 year ago

 --xformers --autolaunch --theme dark --api --listen  --comfyui-listen --webui-comfyui-client-address 192.168.xx.xx  all,your check,try

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2023年8月15日(星期二) 凌晨5:20 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [ModelSurge/sd-webui-comfyui] ConfyUI using domain (Issue #82)

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

Seems not work

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

rookiexjl commented 1 year ago

------------------ 原始邮件 ------------------ 发件人: "ModelSurge/sd-webui-comfyui" @.>; 发送时间: 2023年8月15日(星期二) 凌晨5:20 @.>; @.**@.>; 主题: Re: [ModelSurge/sd-webui-comfyui] ConfyUI using domain (Issue #82)

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

Seems not work

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

ljleb commented 1 year ago

The extension should work for reverse proxy users now. https://github.com/ModelSurge/sd-webui-comfyui/issues/107#issuecomment-1681224759

rookiexjl commented 1 year ago

1692237976438 1692063463456 1692237858214

ljleb commented 1 year ago

Is there a line [sd-webui-comfyui] Created a reverse proxy route to ComfyUI: /sd-webui-comfyui/comfyui in the logs? If not, your setup does not seem to require a reverse proxy to work. This is different from other people using runpod.io for example.

rookiexjl commented 1 year ago

[ComfyUI] Device: cuda:0 NVIDIA GeForce RTX 3070 Laptop GPU : native [ComfyUI] Using xformers cross attention [ComfyUI] [sd-webui-comfyui] Launching ComfyUI with arguments: --listen 0.0.0.0 --port 8189 [ComfyUI] Other computers can use ComfyUI 192.168.xx.xx:7860