MauriceHendrix commented 3 years ago

I added teh author name in brackets to the entity list view, because models at least can have duplicate names, as long as the authors are different. Here is an example fo what it'll look like:

codecov[bot] commented 3 years ago

Codecov Report

Merging #361 (ff47b5b) into master (1dac7de) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          68       68           
  Lines        3768     3768           
  Branches      388      388           
=======================================
  Hits         3588     3588           
  Misses        131      131           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c5aa83...ff47b5b. Read the comment docs.

MauriceHendrix commented 3 years ago

We definitely don't want custom CSS within the templates - it should go in the sass files if needed. Though I'm not sure why it is here.

Looking at the screenshot, it's rather odd having a section titled 'Your models' with an author listed for each! We could (a) retitle it 'Models you can see' or (b) split into two sections 'Your models' and 'Models shared with you'. Which seems better @MichaelClerx @mirams ? I'd suggest also omitting the author name for models you own, and only displaying when the author is someone else.

ow !"£$%^&*. you're right I do think it is only your models for this view. Forget about this!

ModellingWebLab / WebLab

add author name to entity list view #361

Codecov Report