search

ModellingWebLab / WebLab

Django-based front-end for the modelling Web Lab v2
Other
3 stars 2 forks source link

Model group functionality only #374

Closed MauriceHendrix closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #374 (53875a9) into master (261e8ae) will increase coverage by 0.03%. The diff coverage is 96.35%.

:exclamation: Current head 53875a9 differs from pull request most recent head c96540b. Consider uploading reports for the commit c96540b to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   95.22%   95.25%   +0.03%     
==========================================
  Files          68       68              
  Lines        3770     3902     +132     
  Branches      388      398      +10     
==========================================
+ Hits         3590     3717     +127     
- Misses        131      134       +3     
- Partials       49       51       +2
Impacted Files Coverage Δ
weblab/entities/urls.py 100.00% <ø> (ø)
weblab/entities/views.py 92.75% <95.31%> (+0.23%) :arrow_up:
weblab/entities/forms.py 95.48% <96.00%> (+0.20%) :arrow_up:
weblab/core/recipes.py 100.00% <100.00%> (ø)
weblab/entities/admin.py 100.00% <100.00%> (ø)
weblab/entities/models.py 95.40% <100.00%> (+0.40%) :arrow_up:
weblab/experiments/admin.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3109d91...c96540b. Read the comment docs.

MichaelClerx commented 2 years ago

What's the difference between this one and the other one?

MauriceHendrix commented 2 years ago

What's the difference between this one and the other one?

this one ONLY has model grouping functionality. If this one gets reviewed first, then merged the other one will be less work. However if you'd rather review a much bigger PR that's also fine (in that case just review the other one).

MichaelClerx commented 2 years ago

OK. I really don't have any way to review this code. I can look at the interface with the link you sent and say if that looks good or not?

MauriceHendrix commented 2 years ago

OK. I really don't have any way to review this code. I can look at the interface with the link you sent and say if that looks good or not?

That would certainly help.