search

ModellingWebLab / WebLab

Django-based front-end for the modelling Web Lab v2
Other
3 stars 2 forks source link

account deletion statement in privacy #378

Closed MauriceHendrix closed 2 years ago

MauriceHendrix commented 2 years ago

added confirm delete template and updated the mention of deleting accounts in the privacy page

codecov[bot] commented 2 years ago

Codecov Report

Merging #378 (04ece2b) into master (37d3f02) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          68       68           
  Lines        3902     3902           
  Branches      398      398           
=======================================
  Hits         3717     3717           
  Misses        134      134           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d6ee3a...04ece2b. Read the comment docs.

jonc125 commented 2 years ago

It's probably worth adding to this page a note about what will happen to all their models etc - I'm assuming they get deleted? Do we have a test for that?

MauriceHendrix commented 2 years ago

I haven't seen a test for that and I'm not sure what will happen. I'm not fully convinced that everything should be deleted because it may be that other stuff depends on it (experiments, model groups and stories).

jonc125 commented 2 years ago

Ah, looks like we do have some in accounts/tests/test_views.py.

Not deleting things the person owns is quite tricky. We'd need to implement a mechanism to transfer ownership first, then give the option to auto-transfer everything when deleting the account.

MauriceHendrix commented 2 years ago

Ah, looks like we do have some in accounts/tests/test_views.py.

Not deleting things the person owns is quite tricky. We'd need to implement a mechanism to transfer ownership first, then give the option to auto-transfer everything when deleting the account.

I just tried it, yes it just gets deleted and actually posentially leeds to an error in stories, but ok that's fixable.