Closed MauriceHendrix closed 2 years ago
How did this get to 37 commits? And what is the change? I can see the difference, but what's the reasoning?
How did this get to 37 commits? And what is the change? I can see the difference, but what's the reasoning?
it should be 1 commit only 2 files changed, not wure what's happened there!
Merging #410 (a71ce40) into master (208d292) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 95.64% 95.68% +0.04%
==========================================
Files 75 76 +1
Lines 4388 4431 +43
Branches 471 477 +6
==========================================
+ Hits 4197 4240 +43
Misses 141 141
Partials 50 50
Impacted Files | Coverage Δ | |
---|---|---|
weblab/entities/forms.py | 95.48% <ø> (ø) |
|
weblab/experiments/views.py | 99.22% <ø> (ø) |
|
weblab/stories/apps.py | 45.45% <ø> (ø) |
|
weblab/stories/templatetags/stories.py | 100.00% <ø> (ø) |
|
weblab/stories/urls.py | 100.00% <ø> (ø) |
|
weblab/entities/models.py | 95.40% <100.00%> (ø) |
|
weblab/experiments/models.py | 99.23% <100.00%> (+<0.01%) |
:arrow_up: |
weblab/stories/admin.py | 100.00% <100.00%> (ø) |
|
weblab/stories/forms.py | 100.00% <100.00%> (ø) |
|
weblab/stories/graph_filters.py | 100.00% <100.00%> (ø) |
|
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update abdd989...a71ce40. Read the comment docs.
@MauriceHendrix does this address #412 and/or #413 ?
@MichaelClerx I don't think it does I think it's just a layout update.
The 'Reset Zoom' and 'Toggle Legend' probably want to stay as the first thing next to the graph (with loads of groups the toggle legend button might disappear to where it is not clickable unless you have already toggled the legend!)
The 'Reset Zoom' and 'Toggle Legend' probably want to stay as the first thing next to the graph (with loads of groups the toggle legend button might disappear to where it is not clickable unless you have already toggled the legend!)
Really? I thought that would be confusing since those buttons relate to the individual models and not the groups?
The 'Reset zoom' button is purely to do with the graph? I don't know exactly how the toggle legend button works, but I thought it was just "show all the legend entries (for groups, individual lines, etc.)" versus "cut it off after so many pixels" and I was worried that "so many pixels" might end up less than the size of the model groups area!
The 'Reset zoom' button is purely to do with the graph? I don't know exactly how the toggle legend button works, but I thought it was just "show all the legend entries (for groups, individual lines, etc.)" versus "cut it off after so many pixels" and I was worried that "so many pixels" might end up less than the size of the model groups area!
true for the reset. the toggle works just on the individual models below it doesn't do anything with the groups above.
@mirams suggested a change to the graph legends. Before the change:![image](https://user-images.githubusercontent.com/52317399/162715869-ec1293fd-2be4-4161-a613-be08d665db98.png)
Now it looks like:![image](https://user-images.githubusercontent.com/52317399/162715736-76b46d8b-0fbd-4aef-a636-fdf7a8790563.png)
(these graphs aren't exactly 100% the same, but it shows the principle)