Closed agrawal-aditi closed 2 years ago
The problem really now is that I'm not sure what the desired behaviour is anymore. when I spoke to @mirams before my holiday we conclused that it wasn't clean and needed thinking about.
The way I see it, you either
let me know what you think @agrawal-aditi @MichaelClerx @mirams also related: #410 #412
If we think big, eventually there should be loads of groups, made by lots of different people (and reflecting lots of different opinions). In that case, you wouldn't want to show all groups on every multi-model graph, but just a restricted set (moderated groups?) For stories, you'd want to specify the groups relevant to your story (which unfortunately makes stories a bit more complex to set up, yes)
I think the groups probably don't want to show up everywhere, agree that there will eventually be loads of groups for anyone interested in looking at batches of models that will quickly get unwieldy to show on every graph. And in Aditi's example above, there are plenty where the categories are ICaL-related and irrelevant (or even misleading) for hERG (e.g. groups to do with calcium channel properties won't even be used in an IKr-only experiment).
So it probably would mean restricting them to stories for now, and then selecting a bunch - probably most usefully various groups (more than one allowed) for a given graph in a story.
right ok that's a reasonably involved change in how the whole thing works
actually... the way we're picking a graph now we're already specifying a group (or a single model).
Would it make more sense to make this a multi-select? Or would it make more sense to have 2 seperate selectors: one for the models that are in the graph and one for the gtoup toggles? @mirams @agrawal-aditi @MichaelClerx
In an ideal world I guess you want two things:
1) which models to display, selected individually or from multiple groups.
2) which groupings to show in toggle, multiple selections from full list
and then those two properties are shown with each graph in story.?
On Thu, 19 May 2022, 12:06 Dr Maurice Hendrix, @.***> wrote:
actually... the way we're picking a graph now we're already specifying a group (or a single model).
[image: image] https://user-images.githubusercontent.com/52317399/169274249-5606474b-1c29-48a3-bec9-b5d34455eb82.png
Would it make more sense to make this a multi-select? Or would it make more sense to have 2 seperate selectors: one for the models that are in the graph and one for the gtoup toggles? @mirams https://github.com/mirams @agrawal-aditi https://github.com/agrawal-aditi @MichaelClerx https://github.com/MichaelClerx
— Reply to this email directly, view it on GitHub https://github.com/ModellingWebLab/WebLab/issues/413#issuecomment-1131551250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRVGA3V2FB6WYR4NHSMQ3VKYOBZANCNFSM5UV2LJ3Q . You are receiving this because you were mentioned.Message ID: @.***>
more along these lines @mirams ?
Yeah, I guess for convenience you might want to select all models at the top from group(s) too, with something like the existing menu but allowing multiple selections, i.e. "Select Model(s) or Model Group(s) shown in graph".
I think the available toggles being separate probably makes sense - so you can define what is interesting on a case-by-case basis (e.g. just include gating type, or species or cell type or whatever). Makes it a bit harder for someone to do a new comparison you hadn't thought of, but without overwhelming them with all possible options, I can't see an easy way to do that. What do you think @agrawal-aditi @MichaelClerx ?
Yeah, I guess for convenience you might want to select all models at the top from group(s) too, with something like the existing menu but allowing multiple selections, i.e. "Select Model(s) or Model Group(s) shown in graph". .. not sure I follow?
When picking what models to show, you might want to use groups, so you can just say "ICaL Study All Models" rather than selecting them individually. Like you can at the moment.
I agree that the existing toggle options make sense for the purpose of selecting what models should go in -> someone may only want to study a group that is already defined and has say 40 models. So it would be inconvenient to select all 40 of those models individually. -> So existing way of selecting models/groups of models is pretty good.
At this point I'd like to clarify that model group may mean different things to us:
What is needed is something like the bottom panel in the mockup Maurice has shown where you can select which toggle should appear in the story (ie which tag associated with a model should show up for a story can be defined by the user)
I don't think we are doing anything with metadata/tags here at the moment! Just two separate uses of the model groups that you create under the "My Files -> Model Groups". Firstly to decide what models to put in the graph, and secondly to decide what toggle options to show underneath it. If that makes sense?
yes! I probably shouldn't have used the term tag But I think I am on the same page as you, just that the in the mockup shown above we shouldn't remove the ability to select entire model groups in the top panel (where it says-> available models)
yes! I probably shouldn't have used the term tag But I think I am on the same page as you, just that the in the mockup shown above we shouldn't remove the ability to select entire model groups in the top panel (where it says-> available models)
aah i get it I didn't mean to remove groups from that, that was just a slightly lazy copy-paste
ok I get it now ... it's going to be a pretty big change I think
Toggle options for model groups show up even outside a story. See the image below of a comparison of hERG models: https://tinyurl.com/3t6vcy96![private_groups_toggle](https://user-images.githubusercontent.com/56925503/165943314-1cea0cca-4622-439e-abe1-7b2d6621d2dd.png)
The following would be useful features: