Changed the way groups are selected and the editing is randered

[MauriceHendrix]

main changes:

• fixes to toggles
• -ability to select multiple groups/models for a graph
• ability to specify for which groups we want toggles

@agrawal-aditi @MichaelClerx let me know if you're happy with this

https://cardiac.nottingham.ac.uk/weblab/stories/79/edit

[codecov[bot]]

Codecov Report

Merging #416 (0edaebd) into master (208d292) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   95.64%   95.67%   +0.02%     
==========================================
  Files          75       76       +1     
  Lines        4388     4415      +27     
  Branches      471      470       -1     
==========================================
+ Hits         4197     4224      +27     
  Misses        141      141              
  Partials       50       50              

Impacted Files	Coverage Δ
weblab/conftest.py	97.81% <ø> (ø)
weblab/core/recipes.py	100.00% <ø> (ø)
weblab/experiments/processing.py	94.26% <ø> (ø)
weblab/experiments/urls.py	100.00% <ø> (ø)
weblab/stories/apps.py	45.45% <ø> (ø)
weblab/stories/urls.py	100.00% <ø> (ø)
weblab/accounts/views.py	71.05% <100.00%> (-0.75%)	:arrow_down:
weblab/datasets/views.py	94.01% <100.00%> (ø)
weblab/entities/admin.py	100.00% <100.00%> (ø)
weblab/entities/apps.py	100.00% <100.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abdd989...0edaebd. Read the comment docs.

[MichaelClerx]

It would be a nice tweak if the "All" and all/any group options disappeared when there was only 1 model selected. (The Select which groups can be switched on and off in the graph: objects can just be inactivated in this case, no need to remove the checkboxes etc!)

[MauriceHendrix]

Any time I add or remove a model (or group) from the list, it forgets which protocol and CSV it was showing. This makes editing a bit difficult: I wanted to just add a model and now I have to undo that and go back to see which protocol+CSV it was!

good point, just chenged the JS to re-apply the previously selected values (if and only if those remain possible options)

[MauriceHendrix]

It would be a nice tweak if the "All" and all/any group options disappeared when there was only 1 model selected. (The Select which groups can be switched on and off in the graph: objects can just be inactivated in this case, no need to remove the checkboxes etc!)

@MichaelClerx I don't know which "All" and all/any group options do you mean? All options are names of groups?

[MichaelClerx]

Sorry, I meant in the graph! If I only have one model selected as options for the graph, the graph doesn't need a "toggle all", or any other group toggles for that matter

Issue indicated in red below:

Secondary issue in blue :D

[MauriceHendrix]

@MichaelClerx @agrawal-aditi @agrawal-aditi I've made the following changes, let me know if you think it's ready for roll-out on scrambler.

• updated the CSS for the model selection
• changed the javascript, so that it fills in previously selected protocol etc when you change a model (only if those remain viable options).
• used js/css to not show the group toggles if you have only selected 1 group. (used CSS to "grey out" the label, so that it doesn't just disappear
• not showing "All" toggle if there is only 1 trace in the graph

[agrawal-aditi]

I think the changes are fine. One minor thing I observed is that the model selection pane has 'dropped down' (see image below). Although, this returns to normal if I zoom out, pretty sure this 'dropping down' of the panel was not happening before. Nevertheless, I don't think it matters too much?