search

ModellingWebLab / cellmlmanip

CellML loading and model equation manipulation
Other
3 stars 1 forks source link

Add warning if cellml has used numbers with different units #90

Closed skeating closed 5 years ago

skeating commented 5 years ago

I created a cellml file that states a (ms) = 1 (ms) + 1 (second). The transpiler merely adds these producing 2 (dimensionless) and so when calculating units further on code cannot catch the error.

Need to decide whether we try and catch it - and whether we throw an error or merely log a warning

jonc125 commented 5 years ago

I think this is reflected in whether you get the graph with dummies still in, or after substitution. If before, you can spot these issues; if after you can't. So I think this isn't an issue and can be closed?

MichaelClerx commented 5 years ago

I just fixed this behaviour in #148

See tests/test_model_bad_units.py