Modern-Treasury / modern-treasury-node

Node.js library for the Modern Treasury API.
MIT License
27 stars 14 forks source link

LedgerAccountSettlementListParams - Provide created_at, updated_at for filtering? #421

Open jcarlsonautomatiq opened 3 months ago

jcarlsonautomatiq commented 3 months ago

Would it be possible to get filters on creation / updates into the API for the settlement transactions? Currently we are using a settlement to rollup a week of order information but if we get a year in we are going to have a lot of settlements. Does the API already have undocumented params we can use per the guide?

Under: https://docs.moderntreasury.com/platform/reference/list-ledger-account-settlements

/**
export interface LedgerAccountSettlementListParams extends PageParams {
  /**
   * If you have specific IDs to retrieve in bulk, you can pass them as query
   * parameters delimited with `id[]=`, for example `?id[]=123&id[]=abc`.
   */
  id?: Array<string>;

  ledger_transaction_id?: string;

  /**
   * For example, if you want to query for records with metadata key `Type` and value
   * `Loan`, the query would be `metadata%5BType%5D=Loan`. This encodes the query
   * parameters.
   */
  metadata?: Record<string, string>;

  settled_ledger_account_id?: string;

  settlement_entry_direction?: string;
}
kmurase commented 3 months ago

Hey @jcarlsonautomatiq - I'm the PM for Ledgers. We're looking into if we can slot this change into the roadmap for you, we'll keep you posted. Git comments can sometimes slip through the cracks but for future requests if you ping support@moderntreasury.com it'll get back to me!

jcarlsonautomatiq commented 3 months ago

Thanks! I looked around for an API 'please contact us this way' and probably missed that method of communication :)