search

ModernElectron / WarpX

Modern Electron's WarpX repository serves as both a fork of the WarpX code (an advanced electromagnetic Particle-In-Cell code - see https://ecp-warpx.github.io) and the repository for a set of tools used in simulating thermionic devices (mewarpx).
https://mewarpx.readthedocs.io/en/latest/index.html
Other
0 stars 1 forks source link

Fix total step bug #173

Closed KZhu-ME closed 2 years ago

KZhu-ME commented 2 years ago

Currently sim_control will run up to but not through the last time step. This means that if the last time step is a diagnostic step, no diagnostic will be outputted for the last step, as the last step is not run.

Merge https://github.com/ModernElectron/mwxp/pull/46 with this, as an mwxp test fails due to missing package dependency.

codecov-commenter commented 2 years ago

Codecov Report

Merging #173 (d22fdca) into memaster (5f503c6) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           memaster     #173   +/-   ##
=========================================
  Coverage     79.63%   79.63%           
=========================================
  Files            30       30           
  Lines          3884     3884           
=========================================
  Hits           3093     3093           
  Misses          791      791
Impacted Files Coverage Δ
mewarpx/mewarpx/_version.py 100.00% <100.00%> (ø)
mewarpx/mewarpx/sim_control.py 83.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f503c6...d22fdca. Read the comment docs.