search

ModernFlyouts-Community / ModernFlyouts

A modern Fluent Design replacement for the old Metro themed flyouts present in Windows.
https://modernflyouts-community.github.io
MIT License
3.55k stars 192 forks source link

Reveal effect for settings menu #167

Closed Samuel12321 closed 3 years ago

Samuel12321 commented 3 years ago

Just split this from #66 so each thread is specific to the feature.

Samuel12321 commented 3 years ago

Tentatively adding this to the 0.8.2 release, especially as 0.8.X is focusing on the settings menu.

ShankarBUS commented 3 years ago

Well reveal and in-app acrylic are completely possible.

These could be easily added 😄

Poopooracoocoo commented 3 years ago

Is there honestly a point? Microsoft will probably be ditching it because FluentUI for React doesn't have it, which they're increasingly switching, and adapting, to.

Samuel12321 commented 3 years ago

doesn't mean it doesn't look great. Furthermore i doubt they will be dropping it any time soon.

ShankarBUS commented 3 years ago

Fuck it, G A Y flyout! /s Flyout (Woah! this GIF is too low quality. I can assure you the rainbow reveal looks fantastic IRL.)

Enough joking. Let me get on topic.

I guess applying reveal to the buttons in the top bar would be too distracting. My suggestion is to apply reveal effects just to the buttons in the media controls and some buttons in the settings. Reveal effect on any other places would be distracting and may be irritating to some users. What do you think @Samuel12321? What are your thoughts or guidelines?

Samuel12321 commented 3 years ago

I was actually only thinking of the settings menu (navigation bar), for exactly this reason. But yes if we were to apply reveal affect to the flyout it should probably be just to the media buttons.

Samuel12321 commented 3 years ago

Also The reveal affect should be on the buttons themselves not the flyout border as shown by the GIF

ShankarBUS commented 3 years ago

Ok half the work done!

Reveal Border Effect has been implemented in cd3652fec69d5eadd4b06932df25b5b03af37794. (still has some complications. will fix it later) Reveal Background Effect is yet to be done. (that ripple effect while pressing) (Is this important tho?)

@Samuel12321,

Even though I found an easy way to add acrylic effect to our app, we shouldn't do that until #32 is fixed. Because the codebase would change drastically after that. It would be hard to alter the acrylic helpers then. Currently, the demo I showed is hardcoded to depend upon a WPF window ('cause it's easy to detect location & size change). It currently isn't optimized for HWNDs. It's better for us to do it once #32 has been fixed.

Samuel12321 commented 3 years ago

Ok, will remove Acrylic from the 0.8.5 release. Which release were we going to do #32 ?

ShankarBUS commented 3 years ago

v0.10 is max timeline. We should try to fix #32 before v0.9.

Don't add it to any projects because I'm still inconclusive of the solution. Let me ask aΔx before coming to a conclusion.

ShankarBUS commented 3 years ago

We did it bois!

After a series of 4 commits,

  1. cd3652fec69d5eadd4b06932df25b5b03af37794
  2. 5445f96f6a468d203b4a54e541ea3ae8e8f92e9b
  3. 41ac5e16884ae2dab824092e143c16c473ad0d80
  4. bff841fc31b0fcdd791c9daa5fdb05be11cc57a9

Reveal effect is finally implemented properly. I will decouple these in the next release and move them to the ModernWpfCommunityToolkit so that other apps can be benefitted too.

P.S. Bruh, it took me 5 hrs to get the exact same effect as in WinUI. RIP UI designers. Now I understand their pain. @Samuel12321, Oopsie.... I forgot to remove the rainbow flyout border reveal. It's still there but hidden. Could we make this an easter egg? Outlook did something like that this year during Pride Month. Should we? Or should we keep it clean?
ShankarBUS commented 3 years ago

@Samuel12321,

Could we release v0.8.5 now? Only the Chinese Localization issue is pending. We may do it with the next release. Or should we do it immediately? You can merge the awaiting PR. I will do the culture remap later after v0.8.5.

Whatcha say?

Also I didn't even get the v0.8.2 update! I'm still stuck with the v0.8.1 build! Do something!

Samuel12321 commented 3 years ago

We did it bois!

After a series of 4 commits,

  1. cd3652f
  2. 5445f96
  3. 41ac5e1
  4. bff841f

Reveal effect is finally implemented properly. I will decouple these in the next release and move them to the ModernWpfCommunityToolkit so that other apps can be benefitted too.

P.S. Bruh, it took me 5 hrs to get the exact same effect as in WinUI. RIP UI designers. Now I understand their pain.

Well-done @ShankarBUS, Were we going to add reveal to the settings menu navigation headers?

Oopsie.... I forgot to remove the rainbow flyout border reveal. It's still there but hidden. Could we make this an easter egg? Outlook did something like that this year during Pride Month. Should we? Or should we keep it clean?

How large is it? I'm usually a fan of keeping it clean, however a setting to enable it could be added to the personalisation menu. Perhaps community feedback on this would bee helpful. @Poopooracoocoo @Cyberdroid1

Poopooracoocoo commented 3 years ago

it's up to you

ShankarBUS commented 3 years ago

Were we going to add reveal to the settings menu navigation headers?

I'll add them eventually. Sush! I'll kill you mate!
ShankarBUS commented 3 years ago

@Samuel12321,

Answer this https://github.com/ModernFlyouts-Community/ModernFlyouts/issues/167#issuecomment-743043414

prakharb5 commented 3 years ago

Perhaps community feedback on this would bee helpful. @Poopooracoocoo @Cyberdroid1

I guess it can be made into an option. It would be great!

Poopooracoocoo commented 3 years ago

@ShankarBUS ahahahah! I see you saw my cheeky edit!! btw i've seen you on the unigram telegram channel. would love to talk to you guys about stuff outside of this repo!!

ShankarBUS commented 3 years ago

@Poopooracoocoo,

I see you saw my cheeky edit!!

Which one? I'm confused...

Oh the collapsible <details /> edit! Forgot it. Yep! I copied it from yours 😅.

btw i've seen you on the unigram telegram channel.

@Cyberdroid1 and I had a beef so we had to clear it up there.

would love to talk to you guys about stuff outside of this repo!!

You can contact me personally on Discord (ShankarBUS#3086) or Telegram (https://t.me/ShankarBUS). We also have a internal discord group (me, @Samuel12321 and @Cyberdroid1). You can join us there.

You can also connect with other users of ours. https://github.com/ModernFlyouts-Community/ModernFlyouts#connect-with-us

prakharb5 commented 3 years ago

Heya @Poopooracoocoo ! Join the telegram channel/discord server! We don't have any way to contact you!

Samuel12321 commented 3 years ago

Could we release v0.8.5 now?

sure if you want, only question is whether we wanted to add a button for rainbow reveal and the Chinese localisation issue.

Only the Chinese Localization issue is pending. We may do it with the next release. Or should we do it immediately?

I personally think (as long as there isn't too much work involved), that it may be best to do it now so the languages are defined and we don't have any duplicate translation work done.

Also I didn't even get the v0.8.2 update! I'm still stuck with the v0.8.1 build! Do something!

That's strange, v0.8.4 (rebranded 0.8.2 due to annoying store issues) has been in the store for a while now. I'm looking into better ways to sort updates both beta and release. I like the way ear trumpet is using azure pipelines, but will update you with what i come up with.

Samuel12321 commented 3 years ago

Were we going to add reveal to the settings menu navigation headers?

I'll add them eventually. Sush! I'll kill you mate!

hah, just saw that.🤣

Samuel12321 commented 3 years ago

just changed title to reflect what still needs to be added.

ShankarBUS commented 3 years ago

Ah comeon!

I have to do that again 😤.

rainbow reveal

It could stay hidden. We can do something later.

I personally think (as long as there isn't too much work involved), that it may be best to do it now so the languages are defined and we don't have any duplicate translation work done.

Ok merge the PR. Remove zh-CN and zh-TW resources. Imma add the remap. We bout to release v0.8.5.

That's strange, v0.8.4 (rebranded 0.8.2 due to annoying store issues) has been in the store for a while now. I'm looking into better ways to sort updates both beta and release. I like the way ear trumpet is using azure pipelines, but will update you with what i come up with.

Whooooooo, Azure pipelines releasing builds to store? Wouldn't that require "💲💰💵💸 M O N E Y 💲💰💵💸"????? You opened a Dev account in Partner Center not an Organisation account. How would that work with Azure pipelines?

JaiganeshKumaran commented 3 years ago

Microsoft has removed reveal effects from WinUI 2.6 preview so I recommend not to add reveal to be consistent with other Windows apps in the future.

FireCubeStudios commented 3 years ago

Microsoft has removed reveal effects from WinUI 2.6 preview so I recommend not to add reveal to be consistent with other Windows apps in the future.

i dont care rgb reveal is cool

Samuel12321 commented 3 years ago

De-prioritized for now. This would be a post winui 3 thing

prakharb5 commented 3 years ago

So, reveal is officially dying now...

Is it still worth to develop this anymore?

ShankarBUS commented 3 years ago

As @Jaiganeshkumaran & @Cyberdroid1 said, reveal is ded 💀. So, we should drop this 💀

Samuel12321 commented 3 years ago

Agreed, pity I quite liked reveal