ModernFlyouts-Community / ModernFlyouts

A modern Fluent Design replacement for the old Metro themed flyouts present in Windows.
https://modernflyouts-community.github.io
MIT License
3.59k stars 194 forks source link

Bug: Media Switch Direction not properly detected #496

Open jeengbe opened 3 years ago

jeengbe commented 3 years ago

Describe the bug: When listening to a playlist or liked songs on Spotify, skipping and switching to the previous track, the direction the new songs come flying in is seemingly random. This issue does not happen with Groove Music or YouTube.

To Reproduce: Steps to reproduce the behaviour:

  1. Open Spotify
  2. Queue any playlist
  3. Skip a couple of songs, observe

Videos:

https://user-images.githubusercontent.com/51749023/110831711-ce246c00-829a-11eb-9009-91a07bcf8b3e.mp4

OS Version: Windows 10 Pro 10.0.19042 Build 19042

ModernFlyouts Version: 0.9.0.0

Additional context: Tested with Shuffle, Repeat on/off. Issue seems to only occur with Spotify

Edit: See https://github.com/ModernFlyouts-Community/ModernFlyouts/issues/496#issuecomment-797310304 for more details

Samuel12321 commented 3 years ago

Sounds like a Spotify issue to me - @ShankarBUS any thoughts

@jeengbe does this occur with the windows default flyout?

prakharb5 commented 3 years ago

@jeengbe does this occur with the windows default flyout?

Windows one doesn't have animations lol

Samuel12321 commented 3 years ago

oh right, i misinterpreted that, i thought he meant it was skipping to the wrong song, not that the animations weren't going the right way.

jeengbe commented 3 years ago

I believe this is a design issue. A song's track number is determined by its position on the album, not in the current playlist, thus giving arbitrary looking results. The issue does not occur when playing songs from the same album only. Without shuffle, it works perfectly fine, though, enabling shuffle (expectedly) renders the same result. https://github.com/ModernFlyouts-Community/ModernFlyouts/blob/104025668a2778334c859051afe97875f999ae5b/ModernFlyouts.Core/Media/Control/NowPlayingMediaSession.cs#L179-L184

Shouldn't the code cause an enormous number of exceptions for two succeeding songs which are both the first in their albums?

ShankarBUS commented 3 years ago

I believe this is a design issue.

Yeah, I am aware of this issue since I started adding this feature. This is just a blind assumption method. Not accurate. But only Spotify produces this problem. Groove Music works well.

A song's track number is determined by its position on the album, not in the current playlist, thus giving arbitrary looking results.

I am not sure about that. But AFAIK, it must be the position of the song in a playlist. I will verify this.

The issue does not occur when playing songs from the same album only. Without shuffle, it works perfectly fine, though, enabling shuffle (expectedly) renders the same result.

Yeah shuffling doesn't update the track number. Groove Music however works perfectly with this.

Shouldn't the code cause an enormous number of exceptions for two succeeding songs which are both the first in their albums?

I will do something about this ASAP.

ShankarBUS commented 3 years ago

@jeengbe Thank you so much mate!

jeengbe commented 3 years ago

Oh, absolutely no thing, thank you for the beautiful application sir! :D