Existing availability condition is broken after duplicating an activity

[abias]

Hi,

I encountered a problem with this problem when duplicating an activity with this availability condition.

Prerequisites:

• Login as admin
• Create a course A
• Go to course A
• Within the course setttings, enable course completion
• Within the course completion settings, set some completion criteria
• Create a course B
• Go to course B
• Within the course setttings, enable course completion
• Add an activity to the course
• Within the activity settings, add an access restriction "Other course completion" and select course A as 'must be marked as complete'
• Save and return to the course
• Verify that the activity has this restriction: "Not available unless: You have completed course Course A"

Steps to reproduce:

• You are still in course B
• Duplicate the activity

Expected result:

• The duplicated activity has the same restriction: "Not available unless: You have completed course Course A"
• When going to the activity settings, course A is selected within the availability condition

Actual result:

• The duplicated activity has a broken restriction: "Not available unless: You have completed course {$a}"
• When going to the activity settings, no course is selected within the availability condition

Analysis

I expect that this problem happens because the update_after_restore function on https://github.com/MUDOTMY/moodle-availability_othercompleted/blob/master/classes/condition.php#L168-L187 is a full copy of availabilty_completion and is not adapted to handling the reference to a completed courses instead of a completed activity.