ModernLMS / moodle-availability_othercompleted

This plugin allow to restrict access of activities and resources in your course based on other course completion.
6 stars 12 forks source link

Name of course to be completed shows {$a} for Student #33

Open jshrek opened 1 year ago

jshrek commented 1 year ago

I am testing the plugin, and I have added course completion restriction to the top section of a course.

The Admin users sees the name of the previous course fine, but Student user sees {$a}.

See attached screenshot. lock

ishara084 commented 1 year ago

I'm facing the same issue for students.

jasimp commented 1 year ago

i am using version 2021033000 (2021112500) on moodle 3.11 and seeing the message as below "Sorry, this activity is currently hidden"

AsheniPerera commented 1 year ago

@sam-suresh Will you able to fix this issue? We are kind of waiting for the patch.

jshrek commented 1 year ago

WORK AROUND: As a work around, while waiting for this bug to get fixed, I have changed the text as follows:

This works for us because we are always preventing access until the previous class is complete.

adevonshire78 commented 9 months ago

@sam-suresh - a fix would be greatly appreciated

adevonshire78 commented 9 months ago

@jshrek while that is a workaround - it doesnt cater perfectly for the option of completing any of a slection of courses (where a student needs to complete any of a list of courses) as this lists this "You have completed the previous class." as many times as you have optional courses to complete

jshrek commented 9 months ago

@adevonshire78 Yes that is why I said it "works for us". It unfortunately will not work for everybody. Hopefully bug fix will be released soon.

danielneis commented 8 months ago

This usually happen when the course is hidden and the user does not have permission for moodle/course:viewhiddencourses or when the course is in a category where the student/authenticated user does not have permission for moodle/category:viewcourselist Once you fix the capabilities, it works for students.

jshrek commented 8 months ago

@danielneis So I tried changing both these settings for Student role from Not Set to Allow, but it did not fix the problem. The Student already enrolled in the course and the previous course it is supposed to refer too, so this does not appear to solve the issue.

danielneis commented 8 months ago

You may have to adjust the Authenticated User role, because the get_roles function from Moodle that is used by the plugin will test the capability on the category level, not at the course level where the user has the student role.

jshrek commented 8 months ago

@danielneis Just want to confirm that setting category:viewcourselist to ALLOW for the Authenticated user (not Student) did the trick and it is working now. Thank you