search

ModernRonin / ProjectRenamer

Conveniently rename your csproj files
Other
155 stars 14 forks source link

Update Git.cs #29

Closed jakubmaguza closed 3 years ago

jakubmaguza commented 3 years ago

Add quotation marks to avoid error on changing names when path contains space character.

ModernRonin commented 3 years ago

so I guess it's got to do with the single quotes, but maybe you are running on linux or some other *nix and there they work?

and, besides all that, thanks for taking the time to do a PR :-)

jakubmaguza commented 3 years ago

Hello! Yes, I did test it locally, but as you pointed it out, it's working on PowerShell, but don't work on cmd. I didn't check there, my apologize.

If I remember correctly, double quotes will work on both PowerShell and cmd. I did my local test again and seems to me it's working fine.

ModernRonin commented 3 years ago

either tonight or tomorrow after work I'll run all the test scenarios for the testbed repo (unfortunately, automating these is not easy, so I run them manually which is a bit time-consuming) and if all works as expected,I'll merge your PR and create a new release. thank you!

jakubmaguza commented 3 years ago

Thank you for your amazing project!

ModernRonin commented 3 years ago

@jakubmaguza new version is available on nuget - thanks once more for your PR!