search

ModernRonin / ProjectRenamer

Conveniently rename your csproj files
Other
155 stars 14 forks source link

Fixed project path issue on linux #32

Closed ghost closed 3 years ago

ghost commented 3 years ago

Fixed #21 and Fixed #22

As absolute path was containing invalid platform specific relative path and it's originally came from MSBuild object [ProjectInSolution.AbsolutePath].

ghost commented 3 years ago

I have learned many things fixing this issues and grateful for that. Thank you so much that I was able to contribute.

ghost commented 3 years ago

just kept changes specific to issue.

ModernRonin commented 3 years ago

hmm, locally when I add your changes and run the test profiles that are checked into the solution, I hit issues. I invited you to the repo I use as testbed. Can you check it out locally, into C:\Projects\Github\ProjectRenamerTestBed, and then from within VS use the launch config "renamed library to project, in subfolder, no commit, no paket"? Or, you are using VS Code, you maybe have to do this differently, the launch profiles can be found under 'Properties/launchsettings.json'.

If you can't, it's fine, then I'll do it, but that may take a few days because it seems I hurt my shoulder, I need to go and see the doctor.

ghost commented 3 years ago

no worries, will give it a try.

ModernRonin commented 3 years ago

so how is it going? do you need assistance? This weekend I hope to be able to spend some time on this...

ghost commented 3 years ago

Hey @ModernRonin there is no progress from my side currently. FIX suggested by me is also breaking on Linux few more things along the way. So got setup on Windows and Linux to make it happen. Things work correctly if project is not referenced or referencing other project. If you got time sure go ahead but I will also make efforts to fix it. Thanks for the testbed project it really help me understand this project as well.

ModernRonin commented 3 years ago

Did you get the manual test-scenarios from the other repo to work? I've found they are quite helpful.

ghost commented 3 years ago

I have tried all scenarios and not all are passing specially referenced by and referencing to. yes other repo was useful and got copy of it so will be using to do manual tests.

ghost commented 3 years ago

All tests in windows are OK on linux side having minor issues will fix and test on both platforms to make sure it works.

ModernRonin commented 3 years ago

very cool, pranav and thank you for sticking with this!

ghost commented 3 years ago

Hey @ModernRonin , finally able to finish it. have tested on windows and Linux, with 100% successful tests. Test bed project is awesome and really helpful.

ModernRonin commented 3 years ago

I will get to look at this only on the weekend, sorry. But thanks a lot!