search

ModiaSim / Modia3D.jl

Modeling and Simulation of 3D systems
MIT License
74 stars 8 forks source link

paramters of "revertRevoluteKind" ? #139

Closed johhell closed 8 months ago

johhell commented 8 months ago

tried to understand Modia3D and found some functions are not clear for me.

revolute.jl

function revertRevoluteKind defines 2 parameters, but oldChild::Object3D{F} is never used.

https://github.com/ModiaSim/Modia3D.jl/blob/33856e3b785f3116162de2c5cae7e0505ec61897/src/Composition/joints/Revolute.jl#L82

joints.jl

This function is used in joints.jl in function jointSpecificTreatment https://github.com/ModiaSim/Modia3D.jl/blob/33856e3b785f3116162de2c5cae7e0505ec61897/src/Composition/joints/joints.jl#L866 with 2 parameters (oldChild, newChild)

handler.jl

The function jointSpecificTreatment is used in handler.jl in jointSpecificTreatment!(newChild, oldChild) https://github.com/ModiaSim/Modia3D.jl/blob/33856e3b785f3116162de2c5cae7e0505ec61897/src/Composition/handler.jl#L174

newChild here is the first parameter. all other functions uses the order (oldChild, newChild)

AndreaNeumayr commented 8 months ago

Thanks for your hints. I'll change that.

AndreaNeumayr commented 8 months ago

See #140