ModificationStation / StationAPI

A general use API for Fabric Loader mods on legacy Minecraft versions.
86 stars 20 forks source link

Obsidian mines faster than in Vanilla #11

Closed chexo3 closed 2 years ago

chexo3 commented 3 years ago

Easy enough to test. Try mining obsidian in vanilla or in cursed-fabric without STAPI, and then try it with STAPI installed. I consider this a regression as most players expect a library not to change vanilla behavior, at least not without a config option. Poking around it the code leads me to believe this is because mining speed and tool effectiveness have been bound together in a way that they aren't in vanilla.

bald
FluorideHistorian commented 3 years ago

stapi best utility mod

calmilamsy commented 3 years ago

I have talked to mine about adding in a config option to disable/enable this behavior host-side, so expect something like that somewhat soon.

mineLdiver commented 3 years ago

I have talked to mine about adding in a config option to disable/enable this behavior host-side, so expect something like that somewhat soon.

or just move the goddamn behavior to modded blocks only

chexo3 commented 3 years ago

I have talked to mine about adding in a config option to disable/enable this behavior host-side, so expect something like that somewhat soon.

~or just move the goddamn behavior to modded blocks only~

That would work, but I'm also worried about losing the flexibility of having separate tool effectiveness vs mining level. For example. a mod to allow you to move spawners with a special tool, but that special tool is super slow. But you can break them without getting a drop using a normal pick.

calmilamsy commented 3 years ago

You can already use custom overrides per block and per item IIRC.

chexo3 commented 3 years ago

Okay, but why are these two separate behavior being tied together in the first place? They should remain separate to match vanilla behavior better. Vanilla allows for them to be separate easily, you shouldn't have to override the behavior.

chexo3 commented 3 years ago

Have these mechanics been properly decoupled now? I want to be able to use STAPI to port mods but this kind of weird change in vanilla behavior, even if it only affects modded blocks, would be really inconvenient

mineLdiver commented 2 years ago

Fixed with fa9a22c