search

ModificationStation / StationAPI

A general use API for Fabric Loader mods on legacy Minecraft versions.
85 stars 19 forks source link

Celestial Events API #115

Open Atilist opened 5 months ago

Atilist commented 5 months ago

The Celestial Events API now has all the primary features needed to be considered functional. There is also a handful of different example usages in the test mod. This should be ready to be included into Station API

Atilist commented 5 months ago

The recent commit should properly address the requested changes

Atilist commented 4 months ago

About the registry: I was actually considering to use it but was not sure if it makes sense. Is it about preventing events from having identical names or something else entirely?

Atilist commented 4 months ago

A potentially more significant issue I just realized is that I am trying to merge into the master branch while I should be merging into a different branch due to this being a new feature. Should I change the target branch if this needs to be done on my end?

Atilist commented 4 months ago

The newline should be taken care of now

Atilist commented 3 months ago

Got my workspace fixed up, now I can continue work on the API

calmilamsy commented 2 weeks ago

Only thing left as far as I'm concerned is to detach event registering from world load and instead moving it to game init.

Atilist commented 2 weeks ago

I am glad this PR is being picked up again. Thank you for putting in the time and effort to get the biggest flaws sorted out