Cave Generation is bugged with Height and/or Depth values other than the defaults

[TalonFloof]

When using StationAPI's getBottomY and getHeight to change the parameters of the world height and depth. For example, setting getBottomY to -64 and getHeight to 256. The world generator seems to create an abnormally high amount of lava springs in the world compared to an instance with a normal getBottomY value of 0.

Attached below is an example of this abnormally high lava spawn rate. I'm not exactly sure what is causing this issue and have tried for a while to find a source to this problem, with no avail.

To note, the height and depth change is the only mixin that I have applied, no other modifications have been done.

[calmilamsy]

Probably a bad mixin target, I'll have a look when I've got a moment.

[calmilamsy]

Does the lava increase in amount with notably higher world heights?

[TalonFloof]

@calmilamsy No, it happens when the world height is increased and the depth is a value below 0 For instance, if getHeight is 256 and getBottomY is -64

[calmilamsy]

Ah, I think I know what's wrong now.

[TalonFloof]

lmk if you figure out what's wrong, kinda curious what's been causing the issue.

[TalonFloof]

Hmm, not sure if this is related, but I'm noclipping through the ground right now and it looks like it also messes up underground generation in general. I think it's safe to say most of the worldgen is messed up. These issues seem to also occur with any value other than the default height and depth values.

Edit: After fiddling around a bit, I've found it's the cave generation code causing these issues. Everything else works fine but that. It's likely due to the blocks being skewed due to the changed height.

[mineLdiver]

Made a quick fix that modifies the world height constants in the cave generation code, which seems to have fixed the issue completely. Going to make it into a proper fix soon.

[mineLdiver]

Should be fully fixed with 2.0-alpha.2.2