ModificationStation / StationAPI

A general use API for Fabric Loader mods on legacy Minecraft versions.
85 stars 19 forks source link

[Bug] Texture when player is inside block is lava #46

Closed paulevsGitch closed 1 year ago

paulevsGitch commented 1 year ago

Small list of issues in latest StAPI (d6d50a4) that I found:

  1. Block tags are not always loaded and applied to blocks (looks like related to resource loading order). Blocks can have mineable tags or not have these tags randomly after game launch
  2. Translations from land files are not loading (at least for blocks), but are displayed in logs as loaded. Manually added translation keys works fine
  3. Texture when player is inside block is lava, but it should be block side texture
mineLdiver commented 1 year ago
  1. Duplicate of #37
  2. Can you provide an example? Translations seem to work fine on my end
paulevsGitch commented 1 year ago

Can you provide an example? Translations seem to work fine on my end

Yes, here it is, all blocks have correct translation key, and StAPI shows that it loads translation file:

image

But in game they don't get names, and HowManyItem shows them as not translated (I thought that it was HMI bug first, but without it situation was the same). After that I tried to load names manually and that worked fine, so I think that it probably is a StAPI bug. Same translations worked fine in older StAPI versions

mineLdiver commented 1 year ago

Can you provide an example? Translations seem to work fine on my end

Yes, here it is, all blocks have correct translation key, and StAPI shows that it loads translation file:

image

But in game they don't get names, and HowManyItem shows them as not translated (I thought that it was HMI bug first, but without it situation was the same). After that I tried to load names manually and that worked fine, so I think that it probably is a StAPI bug. Same translations worked fine in older StAPI versions

StAPI automatically prepends modid to all translation keys in automatically resolved .lang files, so this seems to work as intended. Try prepending modid to the translation key when registering the block, or use .setTranslationKey(ModID, String) from BlockTemplate interface

paulevsGitch commented 1 year ago

Try prepending modid to the translation key

Thank you, that worked, my quick fix looks like this: block.setTranslationKey(id.toString());

mineLdiver commented 1 year ago

Fixed with d7551b8f63b717026adf14b0b3ffacfa0b703a7c