Block items have different scale

[paulevsGitch]

This issue is related to how vanilla items are rendered: for some reason Notch scaled not full blocks x2 times (probably for slabs), but as a result all custom not blocks will have upscaled models (compare right block with left ones). In vanilla this happens with cactusses

Possible solution - disable that scaling at all. That will also fix some vanilla block rendering issues

[mineLdiver]

Is this really an issue though if it's vanilla behavior?

[paulevsGitch]

Yes, it is fine for vanilla items to be rendered upscaled, but when item was defined with json it should always be correct scale that is specified in this json (which is not happening since upscale modifies all item)

[mineLdiver]

Ah, fair. Gonna look into that.

[mineLdiver]

Actually, I can't seem to reproduce this with a json model? Neither do I see the code that'd apply this scale to json models.

[paulevsGitch]

It can be reproduced for blocks that have:

@Override
public boolean isFullCube() {
    return false;
}

@Override
public boolean isFullOpaque() {
    return false;
}

For example for blocks like these

[paulevsGitch]

Comparison of vanilla blocks, json model with incorrect scale and json model with correct scale

[paulevsGitch]

And these are lines that are responsible for that

[mineLdiver]

And these are lines that are responsible for that

Those lines are only executed for vanilla models though. And I have tried returning false in isFullCube and isFullOpaque in one of my json model blocks and didn't get the effect.

[paulevsGitch]

Looks like I forgot to add json items for that block, so it used vanilla renderer. I will fixed that. In that case scaling is not an issue since it is a vanilla feature