Item rendering is different

[paulevsGitch]

Items defined from code (or vanilla) will be rendered as flat planes while items from jsons will have 3D model

Solution - probably items should be in 2D to fit beta style, and 3D items can be a separate mod

[mineLdiver]

I thought it'd make the most sense to make json models render identical to how they are in modern so there are little to no differences between Blockbench and the StAPI renderer, and then just add some builtin models later on (something like item/generated_legacy) that'd make the models look identical to vanilla beta renderer when inherited.

You can also notice that json items in hands are rendered at a slightly different angle and on ground they float slightly higher, like they are in modern.

I guess I could make vanilla beta renderer default instead if that makes more sense for everyone.

[KydZombie]

Personally I think it would make more sense to have models default to beta's items instead of modern. Then you could potentially have an item/generated_3d model or something if for whatever reason an item needs to use modern rendering explicitly.

[KydZombie]

Actually, would it work to have both an item/generated_2d and an item/generated_3d (or _legacy and _modern whichever way) and item/generated just inherits whichever is set in a config somewhere that defaults to 2d? Then by default everything would be consistent, and there could either be a mod or some part of stapi that when set to 3d it would convert all the non-json items to use 3d-rendering as well?

[mineLdiver]

Implemented 2D items. The implementation is rather awkward, so it was marked as experimental. Gonna leave this open until I adjust everything else to fit beta, such as item floating height, handheld angle, etc.

[KydZombie]

Make sure you don't forget to port the color index stuff too (These are the same item)

[mineLdiver]

Make sure you don't forget to port the color index stuff too (These are the same item)

Should be fixed with https://github.com/ModificationStation/StationAPI/commit/5bc3c11e5cc2a362e6efaf9aa524dd5d371fd349

[mineLdiver]

Gonna close this actually, as the initial inconsistency was fixed and #58 exists.