ModificationStation / StationAPI

A general use API for Fabric Loader mods on legacy Minecraft versions.
86 stars 20 forks source link

Texture pack crash on game launch #89

Closed Abbanon closed 1 day ago

Abbanon commented 10 months ago

So for whatever reason, having certain texture packs in my texturepacks folder is causing StationAPI to crash on launch with an "out of bounds exception" of some kind. They don't even have to be active, just within the texturepacks folder itself. This happens even when StationAPI is the only active mod in my b1.7.3 babric instance of MultiMC. Here's the game log: https://api.paste.ee/p/ymJhG And also here's the texture pack in question: DokuCraft Light CUSTOM - Faithful Font.zip

Screenshot_2

MrMasrozYTLIVE commented 10 months ago

It does crash here

mineLdiver commented 2 days ago

The texturepack doesn't provide its own /misc/dial.png to animate the clock item with, so StAPI correctly falls back to the vanilla animation, however, the texturepack also changes the resolution of item textures, while StAPI expects the animation to be the same resolution as the item's texture, causing the crash.

The solution OptiFine implements is to automatically scale the animation. Going to look into implementing this.

mineLdiver commented 1 day ago

This issue should have been automatically closed by the commit, but I suppose it didn't because the buildbot check failed. Manually closing as completed.