search

ModioAB / caramel

Caramel is a CA Registry Manager
GNU Affero General Public License v3.0
16 stars 5 forks source link

Readjust CI rules to make the CI piplines work on GitHub pull requests #74

Closed Spindel closed 3 years ago

Spindel commented 3 years ago

This adds new rules for the workflow to only cause a single MR pipeline to trigger.

it also fixes the tests to run in the correct image, and drops the "when" flags as it has been deprecated.

Spindel commented 3 years ago

Ping @teoti001 the tests fail properly now, rather than improperly, so that needs to be looked at, however now the pipelines work and the job should trigger neatly as intended after this has been merged.

teoti001 commented 3 years ago

Ping @teoti001 the tests fail properly now, rather than improperly, so that needs to be looked at, however now the pipelines work and the job should trigger neatly as intended after this has been merged.

The fix is to change the image for caramel:test to image: ${BUILD_IMAGE} and that should run.

Spindel commented 3 years ago

Ping @teoti001 the tests fail properly now, rather than improperly, so that needs to be looked at, however now the pipelines work and the job should trigger neatly as intended after this has been merged.

The fix is to change the image for caramel:test to image: ${BUILD_IMAGE} and that should run.

Not quite as simple. commit 427cce4 here already solves that, but the test-case is still broken in the CI environment.

I guess it's because the advanced ansi color codes without checking that TERM is set to something sane ( or for that matter, overriding them in the CI job. )

teoti001 commented 3 years ago

I guess it's because the advanced ansi color codes without checking that TERM is set to something sane ( or for that matter, overriding them in the CI job. )

I've fixed that with printf + escape chars in my own testing, will post a pull req soon.