ModischFabrications / CutSolverFrontend

Simple frontend for CutSolver, a webservice to determine ideal cut placements
https://cutsolver.modisch.me
GNU General Public License v3.0
10 stars 2 forks source link

Feature: Add part name #63

Closed Bouni closed 7 months ago

Bouni commented 7 months ago

This PR is meant to work together with PR https://github.com/ModischFabrications/CutSolver/pull/60 and allows to enter a part name per item which is then displayed on the cut list.

Screenshot 2024-01-19 142800

ModischFabrications commented 7 months ago

Test seem to fail because of invalid test setup, do they work locally for you? Build error points to outdated axios import style, but I've become a bit rusty.

Bouni commented 7 months ago

Have to check tomorrow

Bouni commented 7 months ago

With npm run test:unit all tests succeed for me locally:

Test Suites: 1 passed, 1 total
Tests:       6 passed, 6 total
Snapshots:   0 total
Time:        17.65 s
Ran all test suites.

But I see a ton of warnings and deprecation warnings

Bouni commented 7 months ago

Ok, I can reproduce the error. If I run npm ci it installes packages I guess (not sure) and afterwards npm run test:unit I get the same error as the GH action shows.

After some seraching I fount this jest issue: https://github.com/axios/axios/issues/5101#issuecomment-1288382863

When I add the suggested solution to the jest.config.js it works as before.

I've no idea why it worked in the first place for me 😅

Anyway, I just pushed that change and it should run in the CI as well now

Bouni commented 7 months ago

@ModischFabrications Anything I missed? Would you mind approve a CI run to see if things are right now?

ModischFabrications commented 7 months ago

CI seems to work now, good work 👍🏻 Not sure why I need to approve all runs, might look into it later

Bouni commented 7 months ago

So do you plan to merge this one as well as https://github.com/ModischFabrications/CutSolver/pull/60 soon?

ModischFabrications commented 7 months ago

Yes, the next few evenings.

Bouni commented 7 months ago

Nice 😎

ModischFabrications commented 7 months ago

Also promoted with updated CI here, but the multiarch build seems to take forever. Let's hope it goes through, I would need to exclude non-x64 platforms otherwise.