Incompatibility with Replay Mod?

deli73 commented 2 years ago

Is there an existing issue for this?

[x] I have searched the existing issues

Version information

2.3.8+1.18

Expected Behavior

game launches

Actual Behavior

game crashes during launch with the following error:

[18:39:00] [Render thread/ERROR]: Critical injection failure: LVT in net/minecraft/class_312::method_1598(JDD)V has incompatible changes at opcode 324 in callback mixins.recording.replaymod.json:MixinMouseHelper->@Inject::handleReplayModScroll(JDDLorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;DF)V from mod (unknown).
 Expected: [D, F]
    Found: [D, D]
Available: [D, D, D, I, F]

Reproduction Steps

Install this mod along with the replay mod for 1.18.1
Attempt to launch the game.

Java version

Adoptium Java 17

Additional information

It's possible this is an issue with amecs and not this mod, but we can't be sure because the error fails to describe what the conflict is coming from.

deli73 commented 2 years ago

upon further testing, it appears that amecs alone (even an older version like the one embedded) does not cause this issue, so it's likely coming from this mod. we're not sure where in method 1598 the conflict is, but yeah

Leo40Git commented 2 years ago

Apparently that's Mouse.onMouseScroll, which I don't even touch in this mod... I'll keep this issue open for if I see anything else that might cause incompatibility, though.

ModsByLeo / DontDropIt