ModsByLeo / DontDropIt

Prevents accidental dropping of items via various means.
https://modrinth.com/mod/dont-drop-it
MIT License
13 stars 10 forks source link

Prevent favourited items being moved out of your inventory when shift-clicked #31

Open Oscillate18 opened 2 years ago

Oscillate18 commented 2 years ago

Is there an existing issue for this?

Related problem

I have favourited items that I like to keep on my hotbar that I always accidently shift click into an inventory, leaving them behind.

Suggested solution

Implement a feature that prevents favourited items being moved out of your inventory unless you hold the override button while doing it.

Alternative solutions

N/A

Additional information

No response

Leo40Git commented 2 years ago

This is already a feature! Enable Favorites > Disable Shift-Click.

Oscillate18 commented 2 years ago

This is already a feature! Enable Favorites > Disable Shift-Click.

I have this enabled but it only prevents the item from being shift clicked back into your inventory. It does not work when shift clicking a favourite item out of your inventory.

This feature also does not seem to work at all with chests and barrels, I am able to shift click the item back into my inventory from them whereas items like hoppers and crafting tables prevent the item being shift clicked back.

Leo40Git commented 2 years ago

...huh, could've sworn I made it smarter than that - but looking at the code, it just prevents all shift-clicks (which makes the fact that it doesn't block shift-clicks to move from your inventory even weirder!) Will look into this later.

Oscillate18 commented 2 years ago

...huh, could've sworn I made it smarter than that - but looking at the code, it just prevents all shift-clicks (which makes the fact that it doesn't block shift-clicks to move from your inventory even weirder!) Will look into this later.

Thank you very much, I really appreciate it! This is such a useful mod.