search

ModusCreateOrg / budgeting

Budgeting - React + Redux + Webpack (tree shaking) Sample App
https://budget.modus.app
MIT License
982 stars 298 forks source link

Improve maintainability score to A #195

Open grgur opened 6 years ago

grgur commented 6 years ago

Current maintainability score is B. Code climate shows how to improve that score here: https://codeclimate.com/github/ModusCreateOrg/budgeting

Let's get that A!

nelsonomuto commented 6 years ago

one of the things required is a codeclimate config to ignore the flow-typed directory

nelsonomuto commented 6 years ago

that reduces the number of files being analyzed from over 240 to 177.

then there are a few invalid "duplication" issues being raised, those need to be marked invalid; mostly with regards to the unit tests.

after this it reduces the amount of issues drastically

screen shot 2018-09-22 at 4 48 06 pm
nelsonomuto commented 6 years ago

@grgur I don't have access to the Code Climate as a member so I can't mark anything as "invalid" but here is a link to my code climate report https://codeclimate.com/github/nelsonomuto/budgeting

Here's a PR to add the .codeclimate.yml config to exclude the flow-typed directory: https://github.com/ModusCreateOrg/budgeting/pull/201

grgur commented 6 years ago

@nelsonomuto thank you so much for contributing! This gets us a lot closer to the target https://codeclimate.com/github/ModusCreateOrg/budgeting

I believe the other improvements fall into the fun re-org category :)