ModusCreateOrg / gimbal

Web Performance Auditing tooling
https://labs.moduscreate.com/gimbal-web-performance-audit-budgeting
MIT License
115 stars 8 forks source link

updating step 3 config file usage #161

Open bronz3beard opened 4 years ago

bronz3beard commented 4 years ago

resolves #160

ReadMe.md update This step is added for clarity on being able to use the config file

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Docs update

Please check the type of change your PR introduces:

Does this introduce a breaking change?

Other information

None

mitchellsimoens commented 4 years ago

This shouldn't be needed as here in the code, we look for the config file. The glob that is used is .gimbalrc.{js,json,yaml,yml} and it's using the cwd which defaults to process.cwd() (where you executed the command at). Instead of updating the docs, the bug would need to be found and fixed instead.

bronz3beard commented 4 years ago

@mitchellsimoens Do you know if there is a way I can use the same approach re --config ./filelocation in the github action? I know this is not the desired approach but I would really like to show the usage for gimbal on our GH PRs to the team. Just as a temp fix? If not all good I just wanted to ask. 😃

mitchellsimoens commented 4 years ago

@bronz3beard the entrypoint of the gimbal action is gimbal which means you can use a step's with to add additional args: https://help.github.com/en/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepswith