ModusCreateOrg / gimbal

Web Performance Auditing tooling
https://labs.moduscreate.com/gimbal-web-performance-audit-budgeting
MIT License
115 stars 8 forks source link

`audit` command conflicts with yarn|npm audit #162

Open jaygarcia opened 4 years ago

jaygarcia commented 4 years ago

Describe the bug After onboarding the project, I learned that our instructions suggest we add 'audit' to npm run scripts. Problem is that it conflicts with npm audit and yarn audit and is not good practice.

image

image

mitchellsimoens commented 4 years ago

159 does remove this and you just execute gimbal and it just works. The reason for audit was each audit module was executable individually and audit was the command to run them all... and yea, guess poor choice of name due to the described... just need to get back to v2. ~I think the only thing todo is since we cannot use actions to get the circleci configs back... and then update things and make sure it all still works.~