search

ModusCreateOrg / network-rgb-matrix-display

A library for helping drive large arrays of RGB Matrices with Raspberry Pis
MIT License
12 stars 2 forks source link

Unable to build client #13

Open daveythacher opened 3 years ago

daveythacher commented 3 years ago

I am struggling to build the client. Issues:

I am not a CMake guru, I disabled OpenSSL in my CMake 3.21 build from source. I changed it to use direct-draw-on-buffer, but it then complained about image.bmp. I tried commenting that out. This is on Linux.

I am trying to test my library against this code base. I found two bugs in server. Issues:

daveythacher commented 3 years ago

I am able to build the client here: https://github.com/jaygarcia/network-rgb-matrix-display

jaygarcia commented 3 years ago

Hi @daveythacher !

I am struggling to build the client. Issues:

  • Need CMake 3.17, not CMake 3.14+

I'll update the instructions accordingly.

  • Had to manually disable SDL2 from CMake (maybe there was a command for this?)

I will make a PR to do this. It's likely an artifact from an improper commit. Thank you!

  • CMake wanted to build example that does not exist (CMake indicated it should have been in examples, but I could not find it.)
  • CMake errors out during linking something about CMake -E (I just stopped at this point)

I am not a CMake guru, I disabled OpenSSL in my CMake 3.21 build from source. I changed it to use direct-draw-on-buffer, but it then complained about image.bmp. I tried commenting that out. This is on Linux.

Will run through the onboarding/setup and review for additional errors. :(

I am trying to test my library against this code base. I found two bugs in server. Issues:

  • Possible race condition using mFrameCount to switch buffers inside thread (rare)
  • Pixels per panel is not computed correctly: width * width (easy fix)

Thank you for these. I'll make a PR as well.