search

Moe98 / reddit

Scalable Reddit Replica
17 stars 2 forks source link

Use org.json.simple.JSONObject instead of org.json.JSONObject #25

Open MoFarid opened 3 years ago

ZeyadKhattab commented 3 years ago

@MoFarid Why is this issue open? Will it be implemented or not?

MoFarid commented 3 years ago

@MoFarid Why is this issue open? Will it be implemented or not?

I am not sure when/if @Moe98 and @Lujine will implement it.

Moe98 commented 3 years ago

@MoFarid Why is this issue open? Will it be implemented or not?

I am not sure when/if @Moe98 and @Lujine will implement it.

Idk why it's open 😂

ZeyadKhattab commented 3 years ago

from #8 (I still don't know what does this means). I think @Lujine can tell us if this issue is still relevant since she actually wrote this (I think) image

Lujine commented 3 years ago

Yes, @ZeyadKhattab is right this is why the issue is open. The code is functional, but it's definitely not the best approach. So, after we're done with our tasks we can try to fix this. But until then anyone can feel free to check it out.

ZeyadKhattab commented 3 years ago

but it's definitely not the best approach

@Lujine I am not sure I am not following. Do you mean that the json.simple can do something that the currently used library can't or are you saying that the current library is an overkill? or are you saying something else entirely different?😅.

When I checked the implementation of both libraries, it seemed like org.json had much more features than the simple library.

Lujine commented 3 years ago

I just saw this, I'm sorry 😓

The problem is that, the usage may be confusing. We are using both org.json and simple.json in the same file. And the imports are not great, they're confusing for anyone who doesn't exactly know what we're doing.

I generally think that we should just use org.json. That's just to make the code consistent with all the rest and avoid confusion or stupid bugs.