search

Moebits / Waifu2x-GUI

An app that upscales anime-styled images, gifs, videos, and pdfs with waifu2x.
Other
289 stars 13 forks source link

macOS Universal 2 Binary Support Request #21

Closed jetblackrx89 closed 7 months ago

jetblackrx89 commented 7 months ago

I noticed Intel support got dropped after 0.4.1 for macOS. Could you post Universal 2 binaries? The latest releases are arm64 which are strictly for Apple Silicon based Macs. Thanks.

Moebits commented 7 months ago

Correct, for each platform I usually build the most popular arch, and I have an arm-based mac so the performance is better. But, I can continue building the intel version if there are still lots of people on them.

Universal binary might make a huge filesize so it's better to do it separate but I will have to check.

Moebits commented 7 months ago

v0.5.0 is a universal build

jetblackrx89 commented 7 months ago

Thanks. It seems some architecture-specific dependencies for Node might need to be changed a bit. When launching, it returns:

Uncaught Exception:
Error: Could not load the "sharp" module using the darwin-x64 runtime
Possible solutions:
- Please upgrade Node.js:
Found 16.17.1
Requires ^18.17.0 || ^20.3.0 || >=21.0.0
- Consult the installation documentation:
See https://sharp.pixelplumbing.com/install
at Object.<anonymous> (/Applications/Waifu2x GUI.app/Contents/Resources/app.asar/node_modules/sharp/lib/sharp.js:114:9)
at Module._compile (node:internal/modules/cjs/loader:1141:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1196:10)
at Module.load (node:internal/modules/cjs/loader:1011:32)
at Module._load (node:internal/modules/cjs/loader:846:12)
at f._load (node:electron/js2c/asar_bundle:2:13377)
at Module.require (node:internal/modules/cjs/loader:1035:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object.<anonymous> (/Applications/Waifu2x GUI.app/Contents/Resources/app.asar/node_modules/sharp/lib/constructor.js:10:1)
at Module._compile (node:internal/modules/cjs/loader:1141:14)
Moebits commented 7 months ago

Looks like I have to build it separately since that module only has arm64 or x64 versions (no universal). Thanks for letting me know.

Moebits commented 7 months ago

Tell me if it works it's in the same release 0.5.0

Moebits commented 7 months ago

Actually nvm I can't seem to build it on x64 anymore, all the dmg's are crashing on startup.

If you still want to use it you can try running from the source.

git clone https://github.com/Tenpi/Waifu2x-GUI.git
cd waifu2x-gui
npm install
npm start