Moehammered / switch-remote-play

Let the switch remotely play PC games (similar to steam link or remote play)
GNU General Public License v3.0
301 stars 14 forks source link

Virtual Touch - Resolution Mismatch/Touch #37

Closed bad1dea closed 2 years ago

bad1dea commented 2 years ago

Hey,

Just compiled the latest commits you did to test out the Virtual Touch..

If you don't want me reporting any testing/bugs let me know but.

Virtual Touch -- and Touch Mouse Input

Desktop Resolution: 1440p Switch Resolution: 720p

Touch will only do part of the screen (i.e 720p - from origin 0:0) there's no calculation for touch input from switch to desktop resolution.

Moehammered commented 2 years ago

Hey mate,

Firstly, thanks heaps for taking the initiative to compile and test it yourself. It's very helpful to get testing feedback before a release! :)

Secondly, the touch related features aren't finished yet. The simulated touch mouse is not integrated entirely, only the virtual touch for now.

That said, thank you for catching out this issue. I have only been testing at 720p this entire time. You've reminded to test at other resolutions.

I'll look at fixing this when I do more work on the touch input features.

Thanks so much!

bad1dea commented 2 years ago

NP... I believe the formula is -- didn't bother trying to make changes to your code since you're actively developing it.

(switchTouchX / switchResX) desktopResX (switchTouchY / switchResY) desktopResY

Moehammered commented 2 years ago

@bad1dea Patched up. If you find an issue with the touch co-ordinates being off, feel free to re-open this issue.

Only changes made were to the PC application. Switch app is unaffected.

Thanks for testing out the application. If you find anymore issues with in progress features, feel free to report them. :)

bad1dea commented 2 years ago

Tested - working now the way it's intended now.