Moehammered / switch-remote-play

Let the switch remotely play PC games (similar to steam link or remote play)
GNU General Public License v3.0
302 stars 14 forks source link

Controls are messed up and unconfigurable at all #8

Closed JrRadiant closed 3 years ago

JrRadiant commented 3 years ago

Hi Moehammered! Thank you for your great work!

Unfortunately, all is good for me except the gamepad controls and it's buttons, it just all messed up — i. e. pressing any buttons are causing phantom, for example A = pressing Y, B is = C, moving left stick = pressing all buttons in random order, etc.

I tried both the Xbox 360 preset and DualShock 4 profile, none of them are works for me.

And I cannot configure it via the Hardware Gamepad manager in Windows, too.

My PC configuration is:

Windows 7 with installed KB3033929-x64.msu, Setup.Screen.Capturer.Recorder.v0.12.11.exe, ViGEmBus_Setup_1.16.116.exe and Xbox360_64Eng.exe.

Network: Wifi 5Ghz CPU: Intel 3770 RAM: 24GB 1600 Mhz GPU: AMD R9 Fury SSD: 128 GB

My Switch configuration is:

CPU, RAM: no overclock CFW: Atmosphere M.17.1 System FW: 11.0.1 CFW on NAND (not emummc)

Help, please. (:

JrRadiant commented 3 years ago

It looks like this in the Setting menu (sorry for foreign for you Russian language), all buttons are messed up: scr

Moehammered commented 3 years ago

Hi there Radiant,

I'm very sorry to hear that it's causing issues for you. Thank you for providing your system information :)

I've had this issue once in the past when I accidentally used an old version of switch remote play. I have personally never tested it on Windows 7 but I will make a virtual machine to test and see if I can recreate the issue you are experiencing.

I'm assuming you're using the latest version of switch remote play? Version should be 0.8.1.

Can you try uninstalling ViGEm Bus Driver and reinstalling it? Please make sure to use version 1.16 as version 1.17 or newer is not compatible with Windows 7.

Hopefully we can fix this. :)

JrRadiant commented 3 years ago

Yep, it's version is 0.8.1 and ViGEm is v1.16, reinstalled it and 0 effect at all.:(

I will wait for your researches with the Win7 VM, thank you!

Moehammered commented 3 years ago

Hello JrRadiant.

I have some wonderful news. I have spent the past 2 days testing the bug in Windows 7 on my VM and I have finally discovered what was causing it. I am fairly busy nowadays but I will release a new build within the next 24 ~ 48 hours. I'm sorry I can't do it earlier. Thank you for being patient.

I very much appreciate your detailed error report. You helped me discover a very annoying and serious bug that can potentially occur randomly depending on the network hardware.

Please check the releases within the next 48 hours for the fix. Please test it and let me know if the issue is fixed for you at that time :)

JrRadiant commented 3 years ago

OMG, thank you very much!.. Please take your time, I'll wait patiently.

Thank you!

Moehammered commented 3 years ago

OMG, thank you very much!.. Please take your time, I'll wait patiently.

Thank you!

Hey JrRadiant,

Can you please test the attached version of the program and let me know if the controller works normally?

Just overwrite switch-remote-play-host.exe with the attached version and attempt to connect to it.

Before I make a release, I'd like to let you test it first just to make sure the issue you're experiencing is resolved.

Thanks :) switch-remote-play-host_controller-patch.zip

JrRadiant commented 3 years ago

Wow, super!.. Works as good as intended with Xbox 360 Controller Mode.

Many thanks!

Moehammered commented 3 years ago

I'm very happy to hear that!

I will close this issue when I make the next release. If the controller issue occurs for you again in the new release, feel free to reopen this issue at that time.

Thanks for reporting the issue and being patient.

Enjoy!

JrRadiant commented 3 years ago

Thanks!

Unfortunately, found out another bug: everytime once in a 1-2 minutes, all buttons are pressing randomly and become unresponsive, it looks like ghosting. :( Tested both XBox 360 and PS4 controller profiles, the same bug appears.

I made a video for you to investigate it if you'd wish to see — in this test, I using only two analog sticks, no buttons, ABXY or LR are pressed by me, but at the 3rd second in video they all were pressed at once:

https://user-images.githubusercontent.com/61790774/106758713-0dd4b400-665c-11eb-91e0-ed50ddf62ff7.mp4

Moehammered commented 3 years ago

Thanks for the video demonstration. It seems to look like the same bug. If you do the same thing for a few minutes without using the analog sticks but instead other buttons, does it occur?

The patch I made was to fix some cases where the controller data was sent partially and therefore would be corrupted when read as input. It looks like it is still occurring.

Thanks for testing the patch for me. I'll investigate this again tonight and see if I can get the bug to occur.

Could you please attach a screenshot of all the console text when you first startup switch remote play host? I'd like to see the diagnostic info it displays on your machine.

JrRadiant commented 3 years ago

Yep, but I guess it happens less often without using analog sticks.

Here's full console log text: console_text.txt

Moehammered commented 3 years ago

Hey JrRadiant,

I double checked the code and I had a silly little mistake. Please test this patched version and let me know if the issue is still happening for you.

switch-remote-play-host_controller-patch.zip

JrRadiant commented 3 years ago

Wow, much better, key buttons (ABXY and so on) seems to not pressing all at once for now, I very appreciate it!..

Analog stick ghosting is present, I guess — in this short 23 sec video, on 00:03 and 00:19 sec there're saccades of both sticks to the center of axis (to a neutral position), while I move them in a circle way all the time:

https://user-images.githubusercontent.com/61790774/106877245-bf2e2500-6702-11eb-8c54-6b2ef14ace5a.mp4

Moehammered commented 3 years ago

Hmmm. I noticed it would happen a little bit for me but I figured maybe it was due to the VM networking.

If you hold the stick in one position for a while does it still have some ghosting? (for example, hold the stick up for 25 seconds?)

Also does your PC have WiFi? I'm curious if the issue occurs on both WiFi and ethernet. If you can test via your PC connected to WiFi as well I'd appreciate that.

JrRadiant commented 3 years ago

Yep, it's still the same when holding in one position:

https://user-images.githubusercontent.com/61790774/106887957-18508580-6710-11eb-929e-2b6ed1a2e1b1.mp4

Don't have a WiFi module for PC right now, but if I'll find any I'll try to test it with.

Moehammered commented 3 years ago

OK thanks for checking that for me. I'll investigate it tomorrow. If I figure out the cause I'll make a patch and post it here. Thank you very much for your effort testing this out and reporting it :)

Moehammered commented 3 years ago

Hey JrRadiant,

I've found the issue. It was a different issue than the first one. The first bug was from corrupt network data(which is fixed). This 'ghosting' bug is from the X360 controller resetting every single frame. I've patched it up.

Please test the attached version and let me know if the issue has gone away for you.

switch-remote-play-host_controller-patch-v2.zip

JrRadiant commented 3 years ago

Super, now it seems rock-solid stable.

Thank you again!

PS: If I found out any future inconveniences I'll write you up, if you don't mind.

Moehammered commented 3 years ago

Awesome! I'm glad it's working.

Yeah if future issues happen, feel free to write them.

Thank you very much for your testing. You helped me find 2 critical bugs. :)

I'll be making a release sometime soon, so if the new release causes this issue again please let me know.

Have fun!

(P.S. I will close this issue once I make a public release with this patch included.)

Moehammered commented 3 years ago

Hey JrRadiant,

Sorry to bother you, but could you test the latest release and let me know if the controller works well? https://github.com/Moehammered/switch-remote-play/releases/latest

Thanks.

JrRadiant commented 3 years ago

Thank you for the update, works good as always!

Moehammered commented 3 years ago

Thank you for testing the latest release. Have a nice day. :)