search

Moerill / fvtt-chat-notifications

MIT License
9 stars 6 forks source link

[BUG] "Insert direction" is reversed #16

Open patrickburk1988 opened 3 years ago

patrickburk1988 commented 3 years ago

Describe the bug The "Insert direction" setting doesn't function as expected; "Newest top" behaves like "Newest bottom", and "Newest bottom" like "Newest top". Strangely, the preview shown when editing the module settings appears to work as it should. Possibly unrelated, but there is also a console warning whenever a notification appears or fades out: Invalid property height set to 0 Missing plugin? gsap.registerPlugin() gsap-core.js:84:18

To Reproduce

  1. In the "Game Settings" sidebar tab, go to "Configure Settings" > "Module Settings" > "Hey, listen! - Chat Notifications" > "Settings" > "Settings" tab.
  2. Set the "Insert direction" value to "Newest top". The notification preview should behave as expected (i.e. if your chat log is "A", "B", "C", it should display the notifications top-to-bottom as "C", "B", "A").
  3. Exit the settings. Open a second browser and log into your game as a non GM-player. Make sure one of the browsers is not showing the "Chat Log" sidebar tab. In the other browser, send several chat messages to trigger notifications in the non-"Chat Log" browser. You'd expect "1", "2", "3" to display the notifications top-to-bottom as "3", "2", "1", but it does not.
  4. Repeat this with "Insert direction" set to "Newest bottom" to see the same error, but reversed.

Module incompatibilities I can reproduce this bug in Chrome and Firefox with all other modules disabled.

Screenshots/GIFs/Videos The notification preview working as it should:

The actual notification order being reversed:

The chat log:

Desktop (please complete the following information):

BlackburnUTG commented 3 years ago

I can confirm this bug