search

Moerill / fvtt-chat-notifications

MIT License
9 stars 6 forks source link

[BUG] overlay breaks on /stream page #3

Closed ardittristan closed 3 years ago

ardittristan commented 3 years ago

Describe the bug On the /stream page new messages create a duplicate popup on the top left of the screen

To Reproduce Steps to reproduce the behavior:

  1. Go to 'http://myfoundryurl.com/stream'
  2. Send a new message
  3. See double message

Expected behavior The message should not appear in the top left.

Screenshots/GIFs/Videos image

Desktop:

Moerill commented 3 years ago

So you'd want to have the module being completly disabled for stream view?

ardittristan commented 3 years ago

I think that would be the best option yeah, stream view can easily be detected with if (window.location.pathname === "/stream") {}

Moerill commented 3 years ago

That check may have an issue with people having their fvtt instance in subdirectories (?) like my-cool-domain.com/fvtt then that check would fail. But the body does have the class "stream", so i'm going to check for that one.

Moerill commented 3 years ago

Update pushed, but only for fvtt 0.7.4 since i included the GSAP fix as well