Moerill / fvtt-find-the-culprit

MIT License
8 stars 10 forks source link

Reporting the wrong culprit #1

Closed kakaroto closed 4 years ago

kakaroto commented 4 years ago

Hey, this module is genius! Absolutely great, but it has one big flaw : it didn't give me the actual culprit :( I tried it today to try and figure out which module was causing an issue, and a couple of usability issues :

Other than the usability issues mentioned above, the big issue is that it reported the wrong culprit. After I don't know how many reloads I did and painfully testing the specific use case, it gives me "the culprit is X" and that result made no sense, I tested with that module alone and the issue wasn't there, so I had to redo the whole process but manually this time to find the actual culprit. This may be a off-by-one issue, or a 'using-the-wrong-set' or something, but yeah, it wasn't reliable :( If it had shown the last few candidates, that would have made it easier for me to test afterwards, instead of doing it all over from scratch.

Moerill commented 4 years ago

Ups, ye i seem to have made some mistake somewhere, when i got hacky and just wanted to finish this :see_no_evil: I think i have fixed it now!

Fixed it and added all of your suggestions, although i always show all modules in a small, scrollable subwindow.