search

Moerill / fvtt-mars-5e

GNU Lesser General Public License v3.0
10 stars 13 forks source link

[DOCUMENTATION] incompatibility with module Multiattack-5e #41

Closed davidR1974 closed 3 years ago

davidR1974 commented 3 years ago

Describe the bug Incompatbility with module MultiAttack-5e

Module incompatibilities The MultiAttack-5e (https://github.com/jessev14/Multiattack-5e) interfers with MARS-5e : no action happens when clicking on items and the following message appears in console :

override.js:491 Uncaught (in promise) TypeError: Cannot read property 'altKey' of null at damageRollMA5e (override.js:491) at Item5e.rollDamageMA5e (override.js:435) at MarsItem5e.rollDamage (entity.js:257) at MarsItem5e._getTemplateData (entity.js:118) at async MarsItem5e.displayCard (entity.js:13)

Deactivating module Multiattack-5e solve the issue completely.

Desktop (please complete the following information):

Additional context

davidR1974 commented 3 years ago

Great job on the whole module. .. I wanted to tag this as "documentation" but was not able to find where to change the tag....

Moerill commented 3 years ago

Thanks for the info! And no problem, not sure if you're allowed to change the label? it would be at the right side under "labels", just click on it and uhm.. maybe it works? dunno :sweat: i'll add it to documentation or just do a complete pinned module incompatibility issue at some point..

Moerill commented 3 years ago

Linked to this issue in known module incompatibilties. Will close this, which does not mean its getting resolved, just that i don't want it in the open issue list..