search

Moerill / fvtt-mars-5e

GNU Lesser General Public License v3.0
10 stars 13 forks source link

[BUG] Minor Conflict with Monster Blocks #80

Open JLtheking2 opened 3 years ago

JLtheking2 commented 3 years ago

Monster Blocks has a feature that automatically generates attack descriptions. Here is what it looks like: image

This attack description is automatically generated for a weapon with no description, purely out of its details settings. image image

This is a useful quality of life feature, as it lets the GM create monsters from scratch really easily and looks picture perfect with a regular 5e stat block.

However, with Mars enabled, [prof] and [mod] tags start to appear in the automatically generated attack descriptions. image

This more or less ruins the quality of life feature from Monster Blocks as it is distracting and clutters up the previously clean UI.

No errors appear in the console when loading the game and opening an NPC using the Monster Blocks sheet. So, my guess is that Mars is doing something behind the scenes that is usually hidden, but somehow unearthed by Monster Blocks' automation?

It's not too big of an issue and not game-breaking by any means, merely an inconvenience. Just wanted to highlight to you as I'm pretty sure Monster Blocks has been starting to gain a large base of users :)

Appreciate you taking the time to look in to this!

Tested on Chrome. FVTT 0.7.9, DnD5e 1.2.4, Mars 1.3.1, Monster Blocks 2.4.7.

Moerill commented 3 years ago

Solved already with the #75 fix (kind of accidently.. )

Moerill commented 3 years ago

Thanks for the good write up though! :)

JLtheking2 commented 3 years ago

This issue still appears on the latest release of 1.4 😢

Moerill commented 3 years ago

I'll reopen this, since i seem to have broken it again.

But this time its bit more complicated and not sure how i want to tackle this. Since i have to overhaul a few roll things for 0.8.x i'll push this to 0.8.x as well. (Not so high prio imo, since its not breaking anything, just showing more details than people seem to wish)

Moerill commented 3 years ago

Looking at it it will probably have to resolve itself with 0.8.x and me, monsterblocks and dnd5e system adjusting to it.