search

Moerill / fvtt-pointer

MIT License
6 stars 16 forks source link

Update for Foundry version 9 #30

Closed spaceotter closed 2 years ago

spaceotter commented 2 years ago

Changes the keybinding method to the new ClientKeybindings system. This unfortunately prevents binding the ping to a mouse click.

Resolves #29 .

spaceotter commented 2 years ago

It should be possible to enable the mouse option again with some extra checkbox or something, it would be a bit cumbersome.

Moerill commented 2 years ago

Thanks for the work!

But not having the mouse as option sounds kind of bad to me - it'd be kind of important to me to keep that functionality.
Isn't it possible to just defer the keypress event to the new keybinding system instead of a DOM event? shouldn't that kind of keep everything the way it was? Or is the keybind system to limiting for this?

spaceotter commented 2 years ago

The suggestion was to use a keybinding to toggle a variable and then trigger pings from the mouse API. So there could be a checkbox that switches that on. Also there is some issue with the localization not appearing in the keybinding gui. I'll see what can be done.

Moerill commented 2 years ago

Integrated your other PR. Thanks again for this!!