Moerill / token-mold

MIT License
27 stars 33 forks source link

[BUG] Getting errors w/ 10.291 in Starfinder 0.22.1 #152

Closed MakaPhil closed 1 month ago

MakaPhil commented 1 year ago

Describe the bug Dragging a token onto the battle map does not preface or append the token name. This seems to be due to the fact that the module is not able to link to any of the dictionaries or rollable tables.

This does produce an error as follows: actor.js:38 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'pack') [Detected 2 packages: system:sfrpg, token-mold] at new ActorSFRPG (actor.js:38) at TokenMold._getBarAttributes (token-mold.js:941) at Object.fn (token-mold.js:90) at Function.#call (foundry.js:724) at Function.callAll (foundry.js:681) at Game.setupGame (foundry.js:7952) at async Game._initializeGameView (foundry.js:8999) at async Game.initialize (foundry.js:7825)

To Reproduce Steps to reproduce the behavior:

  1. Install system: Starfinder 0.22.1
  2. With Token-Mold enabled
  3. Drag an actor from the Actors tab on to a battle map, seems to be any type of actor
  4. See error

Expected behavior The token dragged onto the battle map gets an adjective assigned.

Desktop (please complete the following information):

Additional context I'm not sure if you accept pull requests, but I've solve the issue for myself, just wanted to file this bug so that you're aware.

Thanks for the great module!

Geekswordsman commented 1 year ago

Current version is frozen; the codebase is getting overhauled for v3 and I will make sure this is not an issue.

BeardedGnome commented 1 month ago

I'm closing all issues from version early than v2.22.2. Please update to Foundry V12, retest, and open a new issue if you're still having problems.