Moerill / token-mold

MIT License
27 stars 33 forks source link

[BUG] Settings Save Button unclickable when Window Controls module is enabled #158

Closed FeistyMango closed 1 day ago

FeistyMango commented 1 year ago

Describe the bug When clicking the Save and Close button in the Settings dialog, it does not perform the save action. Rather, it fires the Window Controls' minimize event handler instead.

To Reproduce Steps to reproduce the behavior:

  1. Enable the Windows module
  2. Open the Actors tab
  3. Click the Settings button for token-mold
  4. Save button will be combined with the _ button for Window Controls module
  5. Clicking this button triggers the Windows module event handler rather than running the save handler

Expected behavior The Settings dialog window places the save button in the upper right corner. From a UX standpoint, this is pretty uncommon to place buttons in the corner locations of a dialog box. I think it was a reasonable UX choice by the Windows module to place its icons in that area as it's specifically trying to emulate OS window functionality. Rather a fixed position button within the form would be more standard.

Module incompatibilities This is an integration bug with modules like Windows that place things in the corner of the dialog header across all dialogs. https://github.com/saif-ellafi/foundryvtt-window-controls

Screenshots/GIFs/Videos image image

Desktop (please complete the following information):

BeardedGnome commented 1 day ago

I'm closing all issues from version early than v2.22.2. Please update to Foundry V12, retest, and open a new issue if you're still having problems.