Describe the bug
When clicking the Save and Close button in the Settings dialog, it does not perform the save action. Rather, it fires the Window Controls' minimize event handler instead.
To Reproduce
Steps to reproduce the behavior:
Enable the Windows module
Open the Actors tab
Click the Settings button for token-mold
Save button will be combined with the _ button for Window Controls module
Clicking this button triggers the Windows module event handler rather than running the save handler
Expected behavior
The Settings dialog window places the save button in the upper right corner. From a UX standpoint, this is pretty uncommon to place buttons in the corner locations of a dialog box. I think it was a reasonable UX choice by the Windows module to place its icons in that area as it's specifically trying to emulate OS window functionality. Rather a fixed position button within the form would be more standard.
Describe the bug When clicking the Save and Close button in the Settings dialog, it does not perform the save action. Rather, it fires the Window Controls' minimize event handler instead.
To Reproduce Steps to reproduce the behavior:
Expected behavior The Settings dialog window places the save button in the upper right corner. From a UX standpoint, this is pretty uncommon to place buttons in the corner locations of a dialog box. I think it was a reasonable UX choice by the Windows module to place its icons in that area as it's specifically trying to emulate OS window functionality. Rather a fixed position button within the form would be more standard.
Module incompatibilities This is an integration bug with modules like Windows that place things in the corner of the dialog header across all dialogs. https://github.com/saif-ellafi/foundryvtt-window-controls
Screenshots/GIFs/Videos
Desktop (please complete the following information):