Update to V11 style data (Deprecated)

Moerill / token-mold

MIT License

27 stars 33 forks source link

Update to V11 style data (Deprecated) #203

Closed BeardedGnome closed 4 months ago

BeardedGnome commented 7 months ago

EDIT: See here: https://github.com/Moerill/token-mold/pull/205

This PR pulls from my master branch which now has changes to allow me to publish from my fork. The linked PR is from the commit before those changes were added and is suitable to merge to Moerill:master.

Original:

ESLint/Prettier made a lot of extraneous changes. The important ones are:

Remove V9 and V10 support
Change actorAttributes to use new V11 system data model as described here: https://foundryvtt.com/article/active-effects/

fixes #202 fixes #197 fixes #186

BeardedGnome commented 7 months ago

@Moerill and @Geekswordsman ,

I apologize for the mess ESLint/Prettier made of your code. Hopefully the v11 fix I made in _actorAttributes() is clear.

BeardedGnome commented 7 months ago

@paladintodd and @JasonSunday ,

Can you see if this change fixes Savage Worlds for you?

JasonSunday commented 7 months ago

It is still the same. token-mold

BeardedGnome commented 7 months ago

Strange. It's working for me. Are you using the version from this PR or using Moerill's release?

JasonSunday commented 6 months ago

Moerill's release.

What is the manifest link to your fork?

BeardedGnome commented 6 months ago

I've never tried installing it from GithHub, but you can try this URL: https://[raw.githubusercontent.com/BeardedGnome/token-mold/master/module.json](https://raw.githubusercontent.com/BeardedGnome/token-mold/master/module.json)

Visovsiouk commented 6 months ago

Hello, @BeardedGnome, I tried using your module from the manifest provided, but there seems to be an error. In your manifest.json you include a release that does not exist.

"download": "https://github.com/Moerill/token-mold/releases/download/v2.21.0/v2.21.0.zip",

You should create a release from a tag in your fork and replace this inclusion with your own something like.

"download": "https://github.com/BeardedGnome/token-mold/releases/download/v2.21.0/v2.21.0.zip",

BeardedGnome commented 6 months ago

@Visovsiouk @JasonSunday

Figured out how to publish a release. Unfortunately, it broke this PR. I'll have to figure out how to fix that now.

Edit: Looks like I'll have to fork a new branch and create a new PR.

BeardedGnome commented 5 months ago

@Visovsiouk @JasonSunday

Does it work for you? https://raw.githubusercontent.com/BeardedGnome/token-mold/master/module.json

BeardedGnome commented 4 months ago

I had to publish a breaking version for Foundry v12:

Foundry v11: https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.21.0/module.json Foundry v12: https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.22.1/module.json