Moerill / token-mold

MIT License
24 stars 33 forks source link

Thinking of removing the overlay #71

Open Moerill opened 3 years ago

Moerill commented 3 years ago

I am thinking of removing the token mold overlay from the module. Why? There exists this awesome tooltip module, doing almost all thing that i want from my overlay, with more options (more incoming with v2.0 "soon"!) to customize, most issues existing here resolved and already having a few features that i was thinking of adding. This would also fit to my "more modern" approach of thinking about module development - more feature focused modules, not big feature suites, like Token Mold was.

I'm also talking with the creator of adding a "overlay mode", where the tooltip is displayed above the token instead of on the sides, so you can keep the known "token mold overlay look"

TLDR: please check out Token Tooltip Alt as alternative to token molds overlay and leave your thoughts here, about what is missing or why you'd like/dislike the switch.

SalieriC commented 3 years ago

I especially like Token mold for its clean looking overlay which fits modern and medieval games alike. I originally installed Token Mold specifically for this feature, everything else was pretty much irrelevant for me and still is. I really like the transparent overlay, much better than the module you mentioned imo. Even if that one gets an overlay feature the background would still annoy me (I don't know if this is configurable as I've never used it). If the overlay gets removed from Token Mold I don't see any more reason to use it at all.

Moerill commented 3 years ago

I really like the transparent overlay, much better than the module you mentioned imo.

The dark theme is kinda transparent, and already close in look to token molds overlay.

If the overlay gets removed from Token Mold I don't see any more reason to use it at all.

which is fine, no reason to use a big module with many features you don#t use, if a one feature module does the job (better).

apoapostolov commented 3 years ago

I really love how far Token Tooltip Alt has gone, but the external panel has always struck me as busy and i much loved the in-token way to show statistics, fewer but the most important to each game. I will be a bit sad if Token Tooltip Alt cannot implement the exact same way of visualization, and I think they might not since they are so focused on the external panel. This is why I am a bit sad to see that functionality retired.

Moerill commented 3 years ago

This is why I am a bit sad to see that functionality retired.

the title is "Thinking of removing the overlay". its not set in stone Also its a slow progress, but i do feel that investing in that module to be awesome and do the job could be the better way instead of trying to fix some of the issues i currently have.

i much loved the in-token way to show statistics

i am talking with Marian, and trying to push him to add those things. As for the overlay instead of tooltip, i'm going to probably do that on my own and send it to him to include.

Moerill commented 3 years ago

Thanks to all for commenting on this - i'm happy to hear that my current approach is liked that much!

apoapostolov commented 3 years ago

If Marian adds in-token visualization the way Token Mold does it, I would happily migrate. I love how far Token Tooltip Alt has gone in power user customization.

apoapostolov commented 3 years ago

Hello, Based on this response https://mail.google.com/mail/u/0/#inbox/FMfcgxwKjBNlZkZWGjpZDGsTMmnMJpTg I do not think Marian understood your proposal, or is willing to have completely different implementation to match yours. I would suggest keeping it along as long as it works. Thanks in advance.

Moerill commented 3 years ago

I can't follow your mail link, buuuut after a lengthy discussion he will still add it. It won't be exactly the same, since it will be fixed on the left of the token and not on the right, but i do think thats acceptable :sweat_smile:

SalieriC commented 3 years ago

I can't follow your mail link, buuuut after a lengthy discussion he will still add it. It won't be exactly the same, since it will be fixed on the left of the token and not on the right, but i do think thats acceptable

From what I see in the preview of his current update ( https://discordapp.com/channels/170995199584108546/648215359895240715/773529451480219698 ) it is nowhere near as sleek and elegant as the one from Token Mold. I would not want to use that as it still covers the surrounding area. :-S

Moerill commented 3 years ago

image

i do think it can be pretty close, besides positioning. (even a bit nicer looking imo!) For my taste it mainly needs to get rid of the shadow and probably the border. The main difference is, that the tooltip keeps it size independent from zoom level. (which is actually a thing i wanted to do for token mold as well, since i find it very annoying to not be able to read a tooltip on a quick glance when zoomed out, which i'm most of the time.) Here an example zoomed in completly, with both the tooltip and the token mold overlay active: image And here zoomed out, to a zoom lvl which i'm often working with, for the purpose of being able to see both i moved the tooltip to be besides the token image

Its not completly there yet, there are still a few small changes i'd like to be included, like a better selection menu for icons and even spacing for the icons used

What is what you're still missing/thinking is sleeker for the token mold overlay?

SalieriC commented 3 years ago

What is what you're still missing/thinking is sleeker for the token mold overlay?

From the video I linked it seems that the overlay still covers the surrounding area when there is more information in it than fits inside of one square. I admit that reading your overlay when zoomed out can be a bit hard but I rather have that than covering the surrounding area.

Moerill commented 3 years ago

Token Mold is doing the same, if you have to much information it will spill over: image

But ye it seems the relative size version will come at some point in the future.

For the time being i'll keep token molds overlay, but will probably not put much work into updating it, while i observe how token tooltip develops.

jalensailin commented 3 years ago

One thing i like about your module is the drop-down menu for choosing which attributes are displayed. I understand that token tooltip alt allows you to type it in yourself because it allows for more complex expressions but I find that having to manually type in attributes is just annoying and thats honestly why I opt for Token Mold's overlay. That and its simplicity

ThingsCouldGetDicey commented 3 years ago

well the thing that was missing from the overlay is to distinguish between npcs/pcs so that you could have more information on the npcs and monsters than you need on the pcs.