[BUG] Size of image not changing correctly

[Zarhog]

Using the template
calculation incorrect The image changes size but the token dos not this leads to some in stabilities and compatability issues with stuff like Midi Automation where it relies on the token size being correct. Please fix this, it should be as simple as changing where the modual edits the token, instead of it overriding it should directely change the size values in Proto token

[Moerill]

Using the template

Thanks for ignoring and removing everything important from the template but keeping this.

calculation incorrect The image changes size but the token dos not

What do you expect, what do you want and why would you expepct it to work this way? Helpful information ehre would be: creature size, the sizes the token got after creating (like.. a screenshot of the token config window) and your scenes settings....
With the information you provided i can only assume things and imo it does look correctly. Tokens are not supposed to be sized below width or height of 1. Thats what the "scale" attribute is for. Why? Cause this historically showed to result in visual issues for different stuff, especially on maps with small grid sizes.

it should be as simple as changing where the modual edits the token

So like somewhere in >50% of the code? :thinking:
If its that easy, why don't you either provide a pull request or point in your issue to what exactly you want to change?
(While it is indeed easy to change, i do not like the assumption of it being easy. Especially not without providing example solutions or even a properly formatted bug report)

instead of it overriding it should directely change the size values in Proto token

Why?

[Zarhog]

So I presume this module is changing the scaler, that for some reason does not actually adjust the size of the token, only the image. where as in my testing the changing the size of the image changes the token size as well. so in conclusion it would seem that the module is targeting the wrong values.

I apologise for not using the template, I was in a hurry last night with a lot of projects on the backburner.

On Sun, Jun 6, 2021 at 5:53 PM Moerill @.***> wrote:

Using the template

Thanks for ignoring and removing everything important from the template but keeping this.

calculation incorrect The image changes size but the token dos not

What do you expect, what do you want and why would you expepct it to work this way? Helpful information ehre would be: creature size, the sizes the token got after creating (like.. a screenshot of the token config window) and your scenes settings.... With the information you provided i can only assume things and imo it does look correctly. Tokens are not supposed to be sized below width or height of 1. Thats what the "scale" attribute is for. Why? Cause this historically showed to result in visual issues for different stuff, especially on maps with small grid sizes.

it should be as simple as changing where the modual edits the token

So like somewhere in >50% of the code? 🤔 If its that easy, why don't you either provide a pull request or point in your issue to what exactly you want to change? (While it is indeed easy to change, i do not like the assumption of it being easy. Especially not without providing example solutions or even a properly formatted bug report)

instead of it overriding it should directely change the size values in Proto token

Why?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Moerill/token-mold/issues/96#issuecomment-855428248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASG2HQRZTFWEH4BEL5E6WP3TRORXPANCNFSM46GBZY4A .

-- Dylan McLean

[Moerill]

seem that the module is targeting the wrong values.

nope. Everything as intended (at least in my tests and no bug report about this since this feature got introduced back in Foundry Beta) and i won't change that for the foreseeable future, as long as no one gives me a good reason to change this around.

I was in a hurry last night with a lot of projects on the backburner.

Then push the report back until you got some time to create it properly next time. Since you want someone to invest their free time to do/fix something for you, its only correct and polite to make it correct!

So I presume

Since you've been ignoring my questions and are "presuming" instead, i'll stop this here and close the issue.