Mofiqul / dracula.nvim

Dracula colorscheme for neovim written in Lua
MIT License
589 stars 102 forks source link

Floating window in lsp_signature.nvim looks wrong #45

Open graves501 opened 1 year ago

graves501 commented 1 year ago

When using the dracula theme with lsp_signature.nvim the floating window looks very bad. Since the looks are colorscheme related according to the lsp_signature.nvim FAQ, someone might want look into fixing it for everyone:

Q:I do not like the pop window background highlight, how to change it?

A: Redefine your NormalFloat and FloatBorder, esp if your colorscheme dose not define it.

image

This is how the floating window looks with the colorscheme nord:

image

Mofiqul commented 1 year ago

I will look into it. FYI: you can override it with setup function.

graves501 commented 1 year ago

Thanks for your time!

In the meantime I tried (re)setting NormalFloat and FloatBorder manually and it seemed like it helped:

vim.api.nvim_set_hl(0, "NormalFloat", {})
vim.api.nvim_set_hl(0, "FloatBorder", {})

image

banjo commented 2 months ago

Any news on this? The provided code does not seem to work for me.

banjo commented 2 months ago

Did not manage to get any borders, but this config at least makes it a big darker so it's easier to differentiate:

  {
    "Mofiqul/dracula.nvim",
    config = function()
      require("dracula").setup({
        overrides = function(colors)
          return {
            NormalFloat = { fg = colors.fg, bg = colors.menu },
          }
        end,
      })
    end,
  },

EDIT:

Another solution to add borders if you are using LazyVim or more specifically noice:

return {
  "folke/noice.nvim",
  enabled = true,
  opts = {
    presets = {
      lsp_doc_border = true,
    },
  },
}