Mofiqul / dracula.nvim

Dracula colorscheme for neovim written in Lua
MIT License
594 stars 103 forks source link

Highlighted line in `nvim-dap-ui` is unreadable #74

Closed Elsie19 closed 1 year ago

Elsie19 commented 1 year ago

image

TylerBarnes commented 1 year ago

This isn't related to dap-ui since it happens just with nvim-dap. After some hunting I found the problem is the debugPc highlight group.

You can set its bg to a nicer color like this:

local dracula = require("dracula")
dracula.setup({
  overrides = {
    debugPc = {
      bg = "#303030"
    }
  },
})
vim.cmd("colorscheme dracula")
Mofiqul commented 1 year ago

@TylerBarnes - Can you share a screenshot after the change? And also can you make a PR?

Elsie19 commented 1 year ago

image

TylerBarnes commented 1 year ago

There's probably a better matching color than the one I added above (not sure which fits the theme best, I did a random grey color without thinking about it too much). I wasn't sure really what debugPC is for but it seems to just be for highlighting the breakpoint line as far as I can tell. If you do a find on this page https://neovim.io/doc/user/nvim_terminal_emulator.html it's near the bottom

TylerBarnes commented 1 year ago

Also I can't make a PR right now but I set a reminder to make one soon

MariaSolOs commented 1 year ago

I recently contributed a PR (https://github.com/Mofiqul/dracula.nvim/pull/101) that added highlight groups for dap, and which should fix this issue.