search

Mofiqul / dracula.nvim

Dracula colorscheme for neovim written in Lua
MIT License
594 stars 102 forks source link

Improve barbar highlight #82

Closed zhou13 closed 1 year ago

zhou13 commented 1 year ago

This PR improves barbar highlight so that it makes the current tab more obvious. This matches the bufferline.nvim theme shipped in lunarvim. I have been using it for a while and it should be stable.

Before:

Screenshot 2023-03-29 at 11 23 10 AM

After:

Screenshot 2023-03-29 at 11 28 59 AM
NoahTheDuke commented 1 year ago

This is significantly harder to read.

zhou13 commented 1 year ago

What do you mean by "significantly harder to read"? I think the contrast is higher due to the usage of darker background... Do you mean you don't like the comment-like fg color for inactive tabs?

zhou13 commented 1 year ago

BTW, the bufferline.nvim in dracular colorscheme is using the same style:

Screenshot 2023-03-30 at 2 30 54 PM

In other words, with this PR, the colorscheme of barbar and bufferline.nvim will be almost the same.

That said, I don't object to improving the readability. However, given the current palette, I don't think there is a better color for inactive tabs.

NoahTheDuke commented 1 year ago

Yeah you're right. I was looking on my phone and it looked worse but in my computer it's good. Apologies.